Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization for es #1285

Merged
merged 1 commit into from Sep 29, 2022
Merged

Localization for es #1285

merged 1 commit into from Sep 29, 2022

Conversation

jonathanruiz
Copy link
Contributor

@jonathanruiz jonathanruiz commented Sep 29, 2022 •
edited by BernieWhite

PR Summary

  • created DocumentStrings.es.resx
  • created DocumentStrings.es-us.resx

Related to #1286 and Azure/PSRule.Rules.Azure#1727

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Code changes
    • Have unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@jonathanruiz
- created DocumentStrings.es.resx
34bb126 
- created DocumentStrings.es-us.resx
@jonathanruiz jonathanruiz marked this pull request as ready for review September 29, 2022 02:59
@jonathanruiz jonathanruiz requested a review from a team as a code owner September 29, 2022 02:59
BernieWhite
BernieWhite approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanruiz Ok looks great. All good to merge.

@BernieWhite BernieWhite merged commit 9cb99f0 into microsoft:main Sep 29, 2022
BernieWhite pushed a commit to BernieWhite/PSRule that referenced this pull request Sep 29, 2022
@jonathanruiz @BernieWhite
- created DocumentStrings.es.resx (microsoft#1285)
a427106 
- created DocumentStrings.es-us.resx
@BernieWhite BernieWhite mentioned this pull request Sep 29, 2022
Merged
7 tasks
BernieWhite added a commit that referenced this pull request Sep 29, 2022
@BernieWhite @jonathanruiz
Fixes markdown parsing of Spanish translated help (#1288)
49204e1 
* - created DocumentStrings.es.resx (#1285)

- created DocumentStrings.es-us.resx

* Fixes markdown parsing for Spanish #1286 (#1287)

Co-authored-by: Johnny Ruiz <johnny@ruizops.com>
@BernieWhite BernieWhite mentioned this pull request Sep 29, 2022
Merged
4 tasks
@jonathanruiz jonathanruiz deleted the jonathanruiz/ES-Culture branch October 3, 2022 02:16
@BernieWhite BernieWhite mentioned this pull request Oct 3, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernieWhite BernieWhite BernieWhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathanruiz @BernieWhite