Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more JSON tests and refactoring #930

Merged
merged 3 commits into from Jan 23, 2022
Merged

Added more JSON tests and refactoring #930

merged 3 commits into from Jan 23, 2022

Conversation

ArmaanMcleod
Copy link
Contributor

@ArmaanMcleod ArmaanMcleod commented Jan 23, 2022 •
edited

PR Summary

Fixes #929.
Fixes #833.

Made the following changes:

  • Added more JSON tests for baselines, module configs and selectors.
  • Refactored HostHelper.cs test methods to fetch language blocks for YAML and JSON.
  • Updated JSON contract resolver to always serialize properties to camelcase.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Code changes
    • Have unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@ArmaanMcleod ArmaanMcleod requested a review from a team as a code owner January 23, 2022 09:10
BernieWhite
BernieWhite approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArmaanMcleod All good to merge. Nice work!

@ArmaanMcleod ArmaanMcleod merged commit e9c2cda into microsoft:main Jan 23, 2022
@ArmaanMcleod ArmaanMcleod deleted the json-tests-and-refactoring branch January 23, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernieWhite BernieWhite BernieWhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Added more tests for JSON resources Add support for JSON based resources
2 participants
@ArmaanMcleod @BernieWhite