Reduce noise in LS output #4656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2018 11:56
zooba
approved these changes
Aug 16, 2018
| /// General language server output relevant to the user | ||
| /// such as information on Python interpreter type. | ||
| /// </summary> | ||
| General = 0, |
There was a problem hiding this comment.
This value isn't defined in LSP, so should start with an underscore (for consistency with other unspecified values)
| @@ -149,5 +149,8 @@ static class StringExtensions { | |||
| public static int IndexOfOrdinal(this string s, string value, int startIndex = 0, bool ignoreCase = false) { | |||
| return s?.IndexOf(value, startIndex, ignoreCase ? StringComparison.OrdinalIgnoreCase : StringComparison.Ordinal) ?? -1; | |||
| } | |||
|
|
|||
| public static bool EqualsIgnoreCase(this string s, string other) | |||
| => string.Compare(s, other, StringComparison.OrdinalIgnoreCase) == 0; | |||
There was a problem hiding this comment.
string.Equals(s, other, StringComparison.OrdinalIgnoreCase)
This was referenced Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address user feedback per microsoft/vscode-python#2405