Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatter crash when file doesn't end in newline #7168

Merged
merged 5 commits into from Sep 20, 2022
Merged

Fix formatter crash when file doesn't end in newline #7168

merged 5 commits into from Sep 20, 2022

Conversation

AdamYoblick
Copy link
Member

@AdamYoblick AdamYoblick commented Sep 20, 2022 •
edited

Fixes #6752

  • Removes the offending line from the diff we get back from the formatter
  • Properly dispose of the ITextEdit when applying edits

@AdamYoblick AdamYoblick requested a review from a team as a code owner September 20, 2022 19:04
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AdamYoblick AdamYoblick merged commit 1d84de3 into main Sep 20, 2022
@AdamYoblick AdamYoblick deleted the formatter_no_newline_bug branch September 20, 2022 21:13
@TBBle TBBle mentioned this pull request Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StellaHuang95 StellaHuang95 StellaHuang95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An error message "Invalid path mode '\' in: No newline at end of file" pops up when for formatting document.
2 participants
@AdamYoblick @StellaHuang95