-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
…ng built with docker in circleci
These commits should be squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These builds should be queued off master, azure-pipelines
was the branch used for dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I realized is missing - the container image names are all the same. They should conform to the same naming structure as the upstream docker hub images and readme.
i.e. for the catalog image
docker build -f /home/vsts/work/1/s/CatalogSrvc/Dockerfile -t pumrpmicroacr.azurecr.io/microsoft/partsunlimitedmrpmicro:645 /home/vsts/work/1/s
--->
docker build -f /home/vsts/work/1/s/CatalogSrvc/Dockerfile -t pumrpmicroacr.azurecr.io/microsoft/pumrp-catalog:645 /home/vsts/work/1/s
…t contain the date/revision as Build.BuildNumber
Fixes #23 |
These are synced the PartsUnlimitedMRPmicro Azure DevOps Builds.