Expose void return type and add reserved UDF names #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adithyaselv
reviewed
May 17, 2024
src/libraries/Microsoft.PowerFx.Core/Functions/UserDefinedFunction.cs
Outdated
Show resolved
Hide resolved
Shpakh-MSFT
reviewed
May 22, 2024
MikeStall
reviewed
May 22, 2024
src/tests/Microsoft.PowerFx.Core.Tests/UserDefinedFunctionTests.cs
Outdated
Show resolved
Hide resolved
…uyen/udf-void-type-and-reserved-names
…thub.com/microsoft/Power-Fx into rnguyen/udf-void-type-and-reserved-names
|
✅ No public API change. |
src/libraries/Microsoft.PowerFx.Core/Functions/UserDefinedFunction.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.PowerFx.Core/Functions/UserDefinedFunction.cs
Outdated
Show resolved
Hide resolved
I know this is not part of your changes, but does this comment still make sense? I couldn't find any definition for "PrimitiveTypeSymbolTable" Refers to: src/libraries/Microsoft.PowerFx.Core/Public/Types/FormulaType.cs:77 in ca62f6f. [](commit_id = ca62f6f, deletion_comment = False) |
|
✅ No public API change. |
Shpakh-MSFT
reviewed
May 23, 2024
src/libraries/Microsoft.PowerFx.Core/Functions/UserDefinedFunction.cs
Outdated
Show resolved
Hide resolved
Shpakh-MSFT
reviewed
May 23, 2024
|
✅ No public API change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With imperative functions, add support for a void UDF type. Also some functions should not be allowed for UDF names like Set, Collect, etc.