Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.2.0 #93

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
68929da
Initialized SelectionManager instance (Working version)
aleksandrlevochkin Aug 8, 2022
61bd08d
Updated packages and config files
aleksandrlevochkin Aug 8, 2022
5f1cc8f
Switched from puppeteer to playwright, and from tslint to eslint + so…
aleksandrlevochkin Aug 9, 2022
7e7bc7d
Fixed code style according to linter's suggestions
aleksandrlevochkin Aug 9, 2022
65a10eb
Updated packages
aleksandrlevochkin Sep 4, 2022
a476bbd
Removed jquery
aleksandrlevochkin Sep 5, 2022
709ea2d
Removed jasmine-jquery dependency and fixed tests
aleksandrlevochkin Sep 7, 2022
9736421
Increased visual's version
aleksandrlevochkin Sep 12, 2022
d5fead7
Increased the visual's version in pbiviz.json as well
aleksandrlevochkin Sep 12, 2022
0fcb231
Changed callback type for addTooltipService method
aleksandrlevochkin Sep 12, 2022
bd05d8f
Increased version in the lock file
aleksandrlevochkin Sep 12, 2022
9542357
Removed redundant files
aleksandrlevochkin Mar 29, 2023
4f8cba5
Updated libraries to latest versions
aleksandrlevochkin Mar 29, 2023
a774bd1
Increased versions of API and visual and fixed Karma config
aleksandrlevochkin Mar 29, 2023
3b08d0f
Added support for keyboard focus
aleksandrlevochkin Mar 29, 2023
a59bfcd
Updated build workflow
aleksandrlevochkin Mar 29, 2023
125d49d
Fixed lodash imports and improved type checks in tests
aleksandrlevochkin Mar 29, 2023
a89a4c2
Polished code
aleksandrlevochkin Mar 29, 2023
6bb6e07
Fixed compilation errors in tests
aleksandrlevochkin Mar 29, 2023
f23a9c8
Updated libraries
aleksandrlevochkin Apr 27, 2023
ed6ad06
Updated changelog and set newest API version
aleksandrlevochkin Apr 27, 2023
6be9ed8
Removed tslint file
aleksandrlevochkin Apr 27, 2023
d8d2565
Created formatting model
aleksandrlevochkin Apr 27, 2023
4a332d5
Migrated to formatting model
aleksandrlevochkin Apr 27, 2023
ec792b9
Changed displayName values for Quaity, Min font size and Max font siz…
aleksandrlevochkin Apr 28, 2023
52f8bc3
Fixed bug with ColorPicker when color was not applied
aleksandrlevochkin Apr 28, 2023
a328594
supportHighlight logic and tests
snapp1 Jun 12, 2023
5be2dba
showAll, removed unused packages, packages version up
snapp1 Jul 20, 2023
f6b701b
moved keys from cababilities to formatting settings
snapp1 Jul 27, 2023
32fa208
removed unused npm packages
snapp1 Jul 27, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
node_modules
dist
coverage
test
.eslintrc.js
karma.conf.ts
test.webpack.config.js
© 2022 GitHub, Inc.
Footer navigation
Terms
20 changes: 20 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
module.exports = {
env: {
"browser": true,
"es6": true,
"es2017": true
},
root: true,
parser: "@typescript-eslint/parser",
parserOptions: {
project: "tsconfig.json",
tsconfigRootDir: ".",
},
plugins: [
"powerbi-visuals"
],
extends: [
"plugin:powerbi-visuals/recommended"
],
rules: {}
};
21 changes: 13 additions & 8 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: build

on:
Expand All @@ -11,21 +8,29 @@ on:

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [12.x]
node-version: [14.x, 16.x, 18.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}

- run: npm audit
continue-on-error: true

- run: npm ci
- run: npm run lint
- run: npm test

- run: npm run eslint --if-present

- run: npm run lint --if-present

- run: npm run package

- run: npm run test
env:
CI: true
16 changes: 0 additions & 16 deletions .travis.yml

This file was deleted.

8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## 2.2.0
* API v5.4.0
* Fixed bug with instantiation of the SelectingManager class
* Updated packages and got rid of vulnerabilities
* Fixed lint errors
* Migrated from enumerateObjectInstances to the new FormattingModel API
* Removed JQuery and split lodash into subpackages

## 2.0.0
* Webpack integration
* Azure Pipelines integration
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# PowerBI-visuals-WordCloud
![Build](https://github.com/microsoft/powerbi-visuals-WordCloud/workflows/build/badge.svg)[![Coverage Status](https://coveralls.io/repos/github/Microsoft/powerbi-visuals-WordCloud/badge.svg?branch=main)](https://coveralls.io/github/Microsoft/powerbi-visuals-WordCloud?branch=main)

> Word Cloud is a visual representation of word frequency and value. Use it to get instant insight into the most important terms in a set.

![Wordcloud chart screenshot](./assets/screenshot.png)
Expand Down
33 changes: 0 additions & 33 deletions azure-pipelines.yml

This file was deleted.

56 changes: 9 additions & 47 deletions capabilities.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"privileges": [],
"dataRoles": [
{
"name": "Category",
Expand Down Expand Up @@ -77,64 +78,46 @@
},
"objects": {
"general": {
"displayName": "General",
"displayNameKey": "Visual_General",
"properties": {
"maxNumberOfWords": {
"displayName": "Max number of words",
"displayNameKey": "Visual_WordCloud_MaxNumberWords",
"type": {
"numeric": true
}
},
"minRepetitionsToDisplay": {
"displayName": "Minimum number of repetitions to display",
"displayNameKey": "Visual_WordCloud_minRepetitionsToDisplay",
"type": {
"numeric": true
}
},
"minFontSize": {
"displayName": "Min font size",
"displayNameKey": "Visual_MinFontSize",
"type": {
"formatting": {
"fontSize": true
}
}
},
"maxFontSize": {
"displayName": "Max font size",
"displayNameKey": "Visual_MaxFontSize",
"type": {
"formatting": {
"fontSize": true
}
}
},
"isBrokenText": {
"displayName": "Word-breaking",
"displayNameKey": "Visual_WordCloud_WordBreaking",
"type": {
"bool": true
}
},
"isPunctuationsCharacters": {
"displayName": "Special characters",
"displayNameKey": "Visual_WordCloud_SpecialCharacters",
"type": {
"bool": true
}
}
}
},
"dataPoint": {
"displayName": "Data colors",
"displayNameKey": "Visual_DataColors",
"properties": {
"defaultColor": {
"displayName": "Default color",
"displayNameKey": "Visual_DefaultColor",
"type": {
"fill": {
"solid": {
Expand All @@ -143,9 +126,12 @@
}
}
},
"isShowAll": {
"type": {
"bool": true
}
},
"fill": {
"displayName": "Fill",
"displayNameKey": "Visual_Fill",
"type": {
"fill": {
"solid": {
Expand All @@ -157,82 +143,56 @@
}
},
"stopWords": {
"displayName": "Stop Words",
"displayNameKey": "Visual_WordCloud_StopWords",
"properties": {
"show": {
"displayName": "Show",
"displayNameKey": "Visual_Show",
"type": {
"bool": true
}
},
"isDefaultStopWords": {
"displayName": "Default Stop Words",
"displayNameKey": "Visual_WordCloud_DefaultStopWords",
"type": {
"bool": true
}
},
"words": {
"displayName": "Words",
"displayNameKey": "Visual_WordCloud_Words",
"type": {
"text": true
}
}
}
},
"rotateText": {
"displayName": "Rotate Text",
"displayNameKey": "Visual_RotateText",
"properties": {
"show": {
"displayName": "Show",
"displayNameKey": "Visual_Show",
"type": {
"bool": true
}
},
"minAngle": {
"displayName": "Min Angle",
"displayNameKey": "Visual_MinAngle",
"type": {
"numeric": true
}
},
"maxAngle": {
"displayName": "Max Angle",
"displayNameKey": "Visual_MaxAngle",
"type": {
"numeric": true
}
},
"maxNumberOfOrientations": {
"displayName": "Max number of orientations",
"displayNameKey": "Visual_WordCloud_MaxOrientationNumber",
"type": {
"numeric": true
}
}
}
},
"performance": {
"displayName": "Performance",
"displayNameKey": "Visual_Performance",
"properties": {
"preestimate": {
"displayName": "Pre-estimate words count to draw",
"displayNameKey": "Visual_PreestimateWordCount",
"type": {
"bool": true
}
},
"quality": {
"displayName": "Quality",
"displayNameKey": "Visual_Quality",
"description": "The value determines the quality of the pre-estimation",
"descriptionKey": "Visual_Description_Quality",
"type": {
"formatting": {
"fontSize": true
Expand All @@ -242,5 +202,7 @@
}
}
},
"supportsMultiVisualSelection": true
"supportsMultiVisualSelection": true,
"supportsKeyboardFocus": true,
"supportsHighlight": true
}
37 changes: 5 additions & 32 deletions karma.conf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,41 +34,26 @@ const testRecursivePath = "test/visualTest.ts";
const srcOriginalRecursivePath = "src/**/*.ts";
const coverageFolder = "coverage";

process.env.CHROME_BIN = require("puppeteer").executablePath();
process.env.CHROME_BIN = require("playwright").chromium.executablePath();

import { Config, ConfigOptions } from "karma";

module.exports = (config: Config) => {
config.set(<ConfigOptions>{
module.exports = (config) => {
config.set({
mode: "development",
browserNoActivityTimeout: 100000,
browsers: ["ChromeHeadless"],
colors: true,
frameworks: ["jasmine"],
frameworks: ["webpack", "jasmine"],
reporters: [
"progress",
"junit",
"coverage-istanbul"
"junit"
],
junitReporter: {
outputDir: path.join(__dirname, coverageFolder),
outputFile: "TESTS-report.xml",
useBrowserName: false
},
singleRun: true,
plugins: [
"karma-coverage",
"karma-typescript",
"karma-webpack",
"karma-jasmine",
"karma-sourcemap-loader",
"karma-chrome-launcher",
"karma-junit-reporter",
"karma-coverage-istanbul-reporter"
],
files: [
"node_modules/jquery/dist/jquery.min.js",
"node_modules/jasmine-jquery/lib/jasmine-jquery.js",
testRecursivePath,
{
pattern: srcOriginalRecursivePath,
Expand All @@ -88,18 +73,6 @@ module.exports = (config: Config) => {
typescriptPreprocessor: {
options: tsconfig.compilerOptions
},
coverageIstanbulReporter: {
reports: ["html", "lcovonly", "text-summary", "cobertura"],
dir: path.join(__dirname, coverageFolder),
'report-config': {
html: {
subdir: 'html-report'
}
},
combineBrowserReports: true,
fixWebpackSourcePaths: true,
verbose: false
},
coverageReporter: {
dir: path.join(__dirname, coverageFolder),
reporters: [
Expand Down