Migrate rhtml dependency from XML to xml2 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for the official CRAN XML package has ceased and it is now classified as an "orphaned" package. It is also difficult to install older versions for windows users. The xml2 CRAN package is actively maintained and easier to install. All XML functions have been swapped with their xml2 equivalents per this gist: https://gist.github.com/nuest/3ed3b0057713eb4f4d75d11bb62f2d66 dependencies.json has also been modified to replace XML with xml2
|
|
uve
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As laid out in issue #341, support for the official CRAN XML package has ceased and it is now classified as an "orphaned" package. It is also difficult to install older versions for windows users.
The xml2 CRAN package is actively maintained and easier to install.
In this commit, all XML functions in
flatten_HTMLhave been swapped with their xml2 equivalents per this gist: https://gist.github.com/nuest/3ed3b0057713eb4f4d75d11bb62f2d66The most notable difference is that XML's
xmlNode()can be passed an attribute vectorattrswhile xml2'sxml_new_root()cannot - that functionality is broken out intoxml_set_attrs()dependencies.jsonhas also been modified to replace XML with xml2