Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informa (Independent Publisher) #3492

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

marpedroche
Copy link
Contributor

@marpedroche marpedroche commented May 16, 2024


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@marpedroche marpedroche requested a review from a team as a code owner May 16, 2024 10:36
Copy link
Contributor Author

@marpedroche marpedroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@microsoft-github-policy-service agree company="Axazure"

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marpedroche,

Kindly go through the below documentation to submit the Independent publisher connector. There many folders in your PR, they are not required.

https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip

image

@marpedroche
Copy link
Contributor Author

@vmanoharas The 'img' folder is used to store the image used in the README file. In my first connector, screenshots were necessary to verify if the connector worked correctly. Please let me know if you don't need these screenshots.

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marpedroche,

Kindly resolve the review comments.

Additionally, all the screen shots should be attached in the conversation, please remove from the files section. Please follow the Independent Publisher documentation as mentioned in the below document.

https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip

independent-publisher-connectors/Informa/readme.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marpedroche

Most of the files are in Spanish it seems, kindly submit your files in English, our team will convert your connector files into other languages.

"denominacionCompleta": {
"type": "string",
"description": "Full Name",
"title": ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide proper title

"valor": {
"type": "string",
"description": "Value",
"title": ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide proper title.

],
"responses": {
"200": {
"description": "default",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use a proper description for the response. you can use something like "OK", "Success", "Bad request", etc.

"operationId": "InformaGet-predictive",
"parameters": [
{
"name": "denominacion",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly correct the spelling "denominacion"

"title": "Decodification Table"
}
},
"description": "Respose field codify"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly correct the spelling "Respose"

"numeroVersionTablasInformacionComercial": {
"type": "number",
"format": "float",
"description": "Comercial information table version number",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly correct the spelling "Comercial"

"description": "Username",
"title": "Username"
},
"formato": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly correct the spelling "formato"

"informacionComercial": {
"type": "object",
"properties": {
"identificacion": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the spelling "identificacion"

},
"description": "datosGenerales"
},
"direcciones": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the spelling "direcciones"

},
"objetoSocial": {
"type": "string",
"description": "Busisness Purpose",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the spelling "Busisness"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants