Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First checkin for Custom connector #570

Merged
merged 10 commits into from
Nov 20, 2020

Conversation

vaibhavrmore1
Copy link
Contributor

@vaibhavrmore1 vaibhavrmore1 commented Nov 17, 2020

First checkin for SkyPoint Cloud Custom connector

  • Purpose to get validated for all schema errors

Please check the following conditions for your PR.

  • apiDefinition.swagger.json is validated using paconn validate command.
  • apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

First checkin for Custom connector
- Purpose to get validated for all schema errors
@vaibhavrmore1 vaibhavrmore1 requested a review from a team as a code owner November 17, 2020 10:24
@ghost
Copy link

ghost commented Nov 17, 2020

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@dougelliott dougelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments, since this will be a certified connector, the artifacts should go within the certified-connectors directory, rather than the custom-connectors directory

custom-connectors/SkyPointCloud/apiDefinition.swagger.json Outdated Show resolved Hide resolved
custom-connectors/SkyPointCloud/apiProperties.json Outdated Show resolved Hide resolved
dougelliott
dougelliott previously approved these changes Nov 19, 2020
@TissonMathew
Copy link

@sriyen-msft CLA is signed.

@sriyen-msft sriyen-msft merged commit b57a4c4 into microsoft:dev Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants