-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First checkin for Custom connector #570
Merged
sriyen-msft
merged 10 commits into
microsoft:dev
from
vaibhavrmore1:SkyPointCloudConnector
Nov 20, 2020
Merged
First checkin for Custom connector #570
sriyen-msft
merged 10 commits into
microsoft:dev
from
vaibhavrmore1:SkyPointCloudConnector
Nov 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First checkin for Custom connector - Purpose to get validated for all schema errors
Closed
dougelliott
suggested changes
Nov 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the comments, since this will be a certified connector, the artifacts should go within the certified-connectors
directory, rather than the custom-connectors
directory
Made review changes, Moved to certified connectors directory
dougelliott
previously approved these changes
Nov 19, 2020
sriyen-msft
requested changes
Nov 19, 2020
@sriyen-msft CLA is signed. |
dougelliott
approved these changes
Nov 20, 2020
sriyen-msft
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First checkin for SkyPoint Cloud Custom connector
Please check the following conditions for your PR.
apiDefinition.swagger.json
is validated usingpaconn validate
command.apiProperties.json
has a valid brand color. Invalid brand colors are#007ee5
and#ffffff
.