PowerShellForGitHub: Disable Progress Bar for Invoke-WebRequest (#229)

Disables the PowerShell progress bar for the `Invoke-WebRequest` cmdlet calls in the `Invoke-GHRestMethod` and `Invoke-SendTelemetryEvent` functions due to known performance issues in PowerShell 5.1. Reference: [Progress bar can significantly impact cmdlet performance.](PowerShell/PowerShell#2138) Fixes #227
microsoft · Jun 10, 2020 · 6e794cb · 6e794cb
1 parent 3c642d2
commit 6e794cb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/GitHubCore.ps1 b/GitHubCore.ps1
@@ -223,8 +223,12 @@ function Invoke-GHRestMethod
                 }
             }
 
+            # Disable Progress Bar in function scope during Invoke-WebRequest
+            $ProgressPreference = 'SilentlyContinue'
+
             [Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12
             $result = Invoke-WebRequest @params
+
             if ($Method -eq 'Delete')
             {
                 Write-Log -Message "Successfully removed." -Level Verbose
@@ -265,6 +269,9 @@ function Invoke-GHRestMethod
 
                 try
                 {
+                    # Disable Progress Bar in function scope during Invoke-WebRequest
+                    $ProgressPreference = 'SilentlyContinue'
+
                     [Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12
                     Invoke-WebRequest @params
                 }

diff --git a/Telemetry.ps1 b/Telemetry.ps1
@@ -181,6 +181,9 @@ function Invoke-SendTelemetryEvent
                 $params.Add("TimeoutSec", (Get-GitHubConfiguration -Name WebRequestTimeoutSec))
                 $params.Add("Body", $bodyAsBytes)
 
+                # Disable Progress Bar in function scope during Invoke-WebRequest
+                $ProgressPreference = 'SilentlyContinue'
+
                 $result = Invoke-WebRequest @params
             }
         }
@@ -211,6 +214,9 @@ function Invoke-SendTelemetryEvent
 
                     try
                     {
+                        # Disable Progress Bar in function scope during Invoke-WebRequest
+                        $ProgressPreference = 'SilentlyContinue'
+
                         Invoke-WebRequest @params
                     }
                     catch [System.Net.WebException]