Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding functionality for Project Cards #163

Merged
merged 15 commits into from
May 12, 2020

Conversation

jpomfret
Copy link
Contributor

@jpomfret jpomfret commented May 4, 2020

Covers:

  • List project cards
  • Get a project card
  • Create a project card
  • Update a project card
  • Delete a project card
  • Move a project card

The tests don't run successfully without the Project code from PR #160, if you want I can rebase this branch with master once/if the core project code gets merged in?

@jpomfret jpomfret mentioned this pull request May 7, 2020
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, you're rocking it with contributions. Thanks so much. 🎆

I do have some feedback for you to consider with this change. Again, thanks so much.

GitHubProjectCards.ps1 Outdated Show resolved Hide resolved
GitHubProjectCards.ps1 Outdated Show resolved Hide resolved
GitHubProjectCards.ps1 Outdated Show resolved Hide resolved
GitHubProjectCards.ps1 Outdated Show resolved Hide resolved
GitHubProjectCards.ps1 Outdated Show resolved Hide resolved
GitHubProjectCards.ps1 Show resolved Hide resolved
GitHubProjectCards.ps1 Outdated Show resolved Hide resolved
Tests/GitHubProjectCards.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubProjectCards.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubProjectCards.tests.ps1 Outdated Show resolved Hide resolved
@HowardWolosky HowardWolosky self-assigned this May 11, 2020
@HowardWolosky HowardWolosky added api completeness This is basic API functionality that hasn't been implemented yet. api-project Work to complete the API's defined here: https://developer.github.com/v3/projects labels May 11, 2020
@HowardWolosky
Copy link
Member

Can you resolve the merge conflict now in the .psd1 again (since a new conflict occurred now that the Columns work was merged in). Once resolved and I've verified a successful test pass, I'll get this one merged in, along with your documentation update. Then I'll rev the version number and publish out a new version.

Thanks for all your help!

@HowardWolosky
Copy link
Member

After your merges, the psd1 is in that bad state again (every line changed). Can you please try the same fix again as you did on the other PR?

@jpomfret
Copy link
Contributor Author

Alright - should be good now...

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks.

@HowardWolosky HowardWolosky merged commit 3a87f2b into microsoft:master May 12, 2020
@HowardWolosky
Copy link
Member

This is now available publicly in 0.12.0. Thanks so much for your contribution. 🎆

@HowardWolosky
Copy link
Member

FYI @jpomfret - In my upcoming pipeline enabling change, I'm going to be changing the signature of New-GitHubProjectCard a little bit. Instead of having to specify ContentId and ContentType in order to associate an issue/pullrequest, users can directly either pass in the IssueId or PullRequestId (and the content type will be inferred based on which is provided). ParameterSets will be used to prevent both being passed in.

@jpomfret
Copy link
Contributor Author

Makes sense to me, thanks for the heads up

@jpomfret
Copy link
Contributor Author

jpomfret commented Aug 9, 2020

Hey @HowardWolosky - has your change for ContentId --> IssueId/PullRequesetId made it to the PowerShell Gallery? Downloaded 0.14 today but it doesn't have this change in, even though I see it in this repo for version 0.14.

(Am finally finishing up a blog post on creating project/issue/cards with PowerShell so wanted to make sure I was accurate 😄)

@HowardWolosky
Copy link
Member

Hi @jpomfret -- 0.14.0 is from 5/30/2020. There are tags in master that will sync you back to the state of the code for any given release. The change I discussed above is in master, but not part of any official release yet. There were a bunch of breaking changes that have been happening, and I have been trying to get all of them into a single release in order to help avoid having a series of releases with breaking changes.

The PR pipeline is just about flushed through of all the breaking changes. I can probably start working on the CHANGELOG update today so that I can release 0.15.0 within the next day or two.

@HowardWolosky
Copy link
Member

@jpomfret -- Decided to do a little more work in the module to take advantage of all the breaking changes in the coming release. I think 0.15.0 will be released by this weekend.

As an FYI, an additional breaking change for your changes is that the Set-GitHub* commands will now be silent by default unless -PassThru is specified. See #276 for more info.

@jpomfret
Copy link
Contributor Author

Sounds good! Sorry for the slow reply, looking forward to the new release. ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api completeness This is basic API functionality that hasn't been implemented yet. api-project Work to complete the API's defined here: https://developer.github.com/v3/projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants