Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dav bowman#319 #333

Merged
merged 9 commits into from
Feb 28, 2019
Merged

Dav bowman#319 #333

merged 9 commits into from
Feb 28, 2019

Conversation

davbowman
Copy link
Contributor

@davbowman davbowman commented Feb 27, 2019

Pull Request (PR) description:

Updating Windows Firewall STIG to version V1R7

This Pull Request (PR) fixes the following issues:

This fixes #319

Task list:

  • Change details added to Unreleased section of README.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@davbowman davbowman added enhancement New feature or request In Progress labels Feb 27, 2019
@davbowman davbowman added this to the 3.0.0.0 milestone Feb 27, 2019
@davbowman davbowman closed this Feb 28, 2019
@davbowman davbowman reopened this Feb 28, 2019
@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #333 into 3.0.0.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           3.0.0.0     #333   +/-   ##
========================================
  Coverage    66.84%   66.84%           
========================================
  Files           15       15           
  Lines          184      184           
  Branches         3        3           
========================================
  Hits           123      123           
  Misses          58       58           
  Partials         3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd06cd5...6a87574. Read the comment docs.

Copy link
Member

@chasewilson chasewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @davbowman and @erjenkin)


CHANGELOG.md, line 31 at r3 (raw file):

to version

This part can be deleted

@davbowman
Copy link
Contributor Author

"to version" removed from CHANGELOG.md, line 31 at r3

Copy link
Member

@chasewilson chasewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @davbowman and @erjenkin)

@erjenkin
Copy link
Member


StigData/Processed/WindowsFirewall-All-1.7.xml, line 6 at r4 (raw file):

      <DuplicateOf />
      <IsNullOrEmpty>False</IsNullOrEmpty>
      <OrganizationValueRequired>False</OrganizationValueRequired>

This needs to be reconverted to include description and also the manually edited field(ie: rawString > RawString)

Copy link
Member

@erjenkin erjenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r3, 1 of 1 files at r4.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @davbowman and @erjenkin)

@erjenkin
Copy link
Member


StigData/Processed/WindowsFirewall-All-1.7.xml, line 6 at r4 (raw file):

Previously, erjenkin (Eric Jenkins) wrote…

This needs to be reconverted to include description and also the manually edited field(ie: rawString > RawString)

looks good

@erjenkin
Copy link
Member

:lgtm:

Copy link
Member

@erjenkin erjenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @davbowman)

Copy link
Member

@chasewilson chasewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 3 of 4 files reviewed, all discussions resolved

@chasewilson chasewilson merged commit 5721316 into 3.0.0.0 Feb 28, 2019
@athaynes athaynes deleted the DavBowman#319 branch March 1, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants