-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dav bowman#319 #333
Dav bowman#319 #333
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0.0.0 #333 +/- ##
========================================
Coverage 66.84% 66.84%
========================================
Files 15 15
Lines 184 184
Branches 3 3
========================================
Hits 123 123
Misses 58 58
Partials 3 3 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @davbowman and @erjenkin)
CHANGELOG.md, line 31 at r3 (raw file):
to version
This part can be deleted
"to version" removed from CHANGELOG.md, line 31 at r3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @davbowman and @erjenkin)
StigData/Processed/WindowsFirewall-All-1.7.xml, line 6 at r4 (raw file):
This needs to be reconverted to include description and also the manually edited field(ie: rawString > RawString) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r3, 1 of 1 files at r4.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @davbowman and @erjenkin)
StigData/Processed/WindowsFirewall-All-1.7.xml, line 6 at r4 (raw file): Previously, erjenkin (Eric Jenkins) wrote…
looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @davbowman)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, all discussions resolved
Pull Request (PR) description:
Updating Windows Firewall STIG to version V1R7
This Pull Request (PR) fixes the following issues:
This fixes #319
Task list:
This change is