Fail build when nugets aren't consolidated (#22233)

* fail build when nugets aren't consolidated * consolidate nugets * change tool install * consolidate nugets * fix message
microsoft · Nov 24, 2022 · b9367c0 · b9367c0
1 parent f41fe14
commit b9367c0
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 1 deletion.
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
@@ -0,0 +1,12 @@
+{
+    "version": 1,
+    "isRoot": true,
+    "tools": {
+        "dotnet-consolidate": {
+            "version": "2.0.0",
+            "commands": [
+                "dotnet-consolidate"
+            ]
+        }
+    }
+}
diff --git a/.pipelines/ci/templates/build-powertoys-steps.yml b/.pipelines/ci/templates/build-powertoys-steps.yml
@@ -7,6 +7,13 @@ steps:
   submodules: true
   clean: true
 
+- task: PowerShell@2
+  displayName: Verifying Nuget packages for PowerToys.sln
+  inputs:
+    filePath: '$(build.sourcesdirectory)\.pipelines\verifyNugetPackages.ps1'
+    arguments: -solution '$(build.sourcesdirectory)\PowerToys.sln'
+    pwsh: true
+
 - task: PowerShell@2
   displayName: Verify Arm64 configuration for PowerToys.sln
   inputs:

diff --git a/.pipelines/verifyNugetPackages.ps1 b/.pipelines/verifyNugetPackages.ps1
@@ -0,0 +1,18 @@
+[CmdletBinding()]
+Param(
+    [Parameter(Mandatory=$True,Position=1)]
+    [string]$solution
+)
+
+Write-Host "Verifying Nuget packages for $solution"
+
+dotnet tool restore
+dotnet consolidate -s $solution
+
+if (-not $?)
+{
+    Write-Host -ForegroundColor Red "Nuget packages with the same name must all be the same version."
+    exit 1
+}
+
+exit 0
diff --git a/src/modules/FileLocksmith/FileLocksmithUI/FileLocksmithUI.csproj b/src/modules/FileLocksmith/FileLocksmithUI/FileLocksmithUI.csproj
@@ -59,7 +59,7 @@
     <PackageReference Include="CommunityToolkit.WinUI.UI" Version="7.1.2" />
     <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.1.5" />
     <PackageReference Include="Microsoft.Xaml.Behaviors.WinUI.Managed" Version="2.0.9" />
-    <PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22000.194" />
+    <PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.1" />
     <PackageReference Include="System.Drawing.Common" Version="6.0.0" />
     <PackageReference Include="WinUIEx" Version="1.8.0" />
     <Manifest Include="$(ApplicationManifest)" />