Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerRename] Undo. #12088

Open
JohnLukeBentley opened this issue Jul 1, 2021 · 10 comments
Open

[PowerRename] Undo. #12088

JohnLukeBentley opened this issue Jul 1, 2021 · 10 comments
Labels
Idea-Enhancement New feature or request on an existing product Product-PowerRename Refers to the PowerRename PowerToy

Comments

@JohnLukeBentley
Copy link

Description of the new feature / enhancement

PowerRename really needs an undo function.

Scenario when this would be used?

An undo function would be useful in all cases but especially when multiple files or folders are renamed in error.

Supporting information

This is a standard feature in, for example, JoeJoe's Rename Master.

JoeJoe's Rename Master is the benchmark tool against we can measure the usefulness of PowerRename generally. Where PowerRename might outshine Rename Master is in keeping the UI simple. But not so simple as to exclude an undo feature. (e.g. shown to the user a simple [Undo] button).

@JohnLukeBentley JohnLukeBentley added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jul 1, 2021
@Aaron-Junker Aaron-Junker added Idea-Enhancement New feature or request on an existing product Product-PowerRename Refers to the PowerRename PowerToy labels Jul 1, 2021
@dedavis6797 dedavis6797 removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jul 1, 2021
@dedavis6797
Copy link
Contributor

Thank you for the suggestion. We can definitely look into implementation details & work prioritization following our general stability efforts.

@JohnLukeBentley
Copy link
Author

Thanks Deondre! Yes indeed: stability efforts would be a priority.

@franky920920
Copy link
Contributor

Maybe undo function with shortcut Ctrl+z will be great.

@JohnLukeBentley
Copy link
Author

I have in mind at least a button, to publise the function. But mapping ctrl+z to it seems reasonable.

There'd be an issue of whether we'd want dialog boxes confirming the undo. Perhaps dialog boxes with a "Don't show this again" checkbox??

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Jul 2, 2021

According to https://docs.microsoft.com/nl-nl/windows/powertoys/powerrename an undo is possible. But not via the GUI and there is no "memory" or "changelog".

@JohnLukeBentley
Copy link
Author

Whoops. Thanks @Jay-o-Way for correcting my (our) oversight.

That seems to work for me:

  • Perform a rename, PowerRename will close.
  • Ensure you are in Windows Explorer.
  • Ctrl + Z will undo. Ctrl + Y will redo.

So my suggestion now becomes: advertise undo and redo functionality in the UI.

That suggestions intersects with #628 "[PowerRename] Do not close - Keep open". If the PowerRename window was, perhaps optionally, kept open after an operation then an [Undo Ctrl + Z] and [Redo Ctrl + Y] button could serve that advertising purpose. Alternatively (and this might work better in the case the close-after-operation option is chosen) some simple text might work. E.g. "In Windows Explorer, after close: undo with Ctrl + Z; redo with Ctrl + Y."

@JohnLukeBentley
Copy link
Author

At least as of 0.49.0 (and also in 0.49.1), if not before, the undocumented Ctrl + Z no longer undoes the file renaming operation.

I suggest that functionality be restored and the UI be updated to publicize that functionality somehow.

@Aaron-Junker
Copy link
Collaborator

At least as of 0.49.0 (and also in 0.49.1), if not before, the undocumented Ctrl + Z no longer undoes the file renaming operation.

I suggest that functionality be restored and the UI be updated to publicize that functionality somehow.

@JohnLukeBentley This still works for me. What OS do you use?

@JohnLukeBentley
Copy link
Author

I'm on Windows 10 Pro (64 bit); 21H1; 19043.1288.

@radonmiser
Copy link

I really need this I fucked up my library and got an error after i press ctrl+Z lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Product-PowerRename Refers to the PowerRename PowerToy
Projects
None yet
Development

No branches or pull requests

6 participants