Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Runner verify app dependencies #13645

Open
1 task
o-l-a-v opened this issue Oct 6, 2021 · 2 comments
Open
1 task

Have Runner verify app dependencies #13645

o-l-a-v opened this issue Oct 6, 2021 · 2 comments
Labels
Area-Runner The PowerToys main executable Priority-3 Bug that is low priority

Comments

@o-l-a-v
Copy link

o-l-a-v commented Oct 6, 2021

Microsoft PowerToys version

0.47.0

Running as admin

  • Yes

Area(s) with issue?

General

Steps to reproduce

If user for some reason decides to uninstall .NET Core Desktop Runtime 3.1.x, it would be great if PowerToys:

  • Did not show 3 error messages, one per module/ program using this dependency.
    MicrosoftTeams-image
  • If Windows reboot and PowerToys is set to auto start, do a check for the dependency and fail to start any PowerToys program, and show one error, not 3.
    • Same if user tries to start PowerToys.

Maybe consider to build PowerToys with .Net Core built in/ self contained deployment?

✔️ Expected Behavior

Graceful exit/ shutdown, with one error message.

❌ Actual Behavior

MicrosoftTeams-image

And some parts of PowerToys continue running.

Other Software

No response

@o-l-a-v o-l-a-v added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 6, 2021
@jaimecbernardo
Copy link
Collaborator

This would be an interesting improvement. Sometimes we get issues where the solution is to install .net. This would prevent those errors.

@crutkas
Copy link
Member

crutkas commented Oct 7, 2021

I think this is an edge case. You uninstalled a runtime dependency that our installer installs. How we're designed with a hub + spoke model, then we're forcing the hub to know more context around individual utilities.

@crutkas crutkas added Area-Runner The PowerToys main executable Priority-3 Bug that is low priority and removed Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 7, 2021
@crutkas crutkas changed the title If .NET Core 3.1.x gets uninstalled - Close gracefully with one error only Have Runner verify app dependencies Oct 7, 2021
@crutkas crutkas added this to the Stability Release milestone Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Runner The PowerToys main executable Priority-3 Bug that is low priority
Projects
None yet
Development

No branches or pull requests

3 participants