Build fails on Windows 10/Visual Studio 2019 Community Edition

[dend]

Microsoft PowerToys version

All

Running as admin

• Yes

Area(s) with issue?

General

Steps to reproduce

1. Fork the repository.
2. Clone the repository.
3. Install dependencies and clone submodules.
4. Try building the solution.

✔️ Expected Behavior

Solution builds.

❌ Actual Behavior

Solution doesn't build.

Other Software

N/A

[davidegiacometti]

Hi @dend
Can you try to manually restore nuget packages and rebuild?

[crutkas]

@davidegiacometti i can repro this with debug mode on a clean solution. Release mode it doesn't seem to happen. I think i may have somehow fixed it with dev/crutkas/removeAnyCpuRef branch, testing on a clean e2e before i do a PR

[crutkas]

on a clean debug build, i get invalid PE header on PowerRenameUILib

[davidegiacometti]

I don't have any problems to build after cleaning the repo (git clean -xdf).
Haven't cleaned nuget cache.

VS2019

[crutkas]

this issue was kicking my butt on the .net 6 upgrade verification

[dend]

Looks like this is still an issue, with the same PowerRenameUILib.winmd

[dend]

Clearing the NuGet package cache and then restoring it does nothing. Looks like the issue is still exactly the same.

[jaimecbernardo]

Tried replicating this some times, but without success. Does this still occur in Visual Studio 2022? /needinfo

[crutkas]

I can get this to happen still. I did a fresh clone. Built, clean, then build again

[ghost]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

[jaimecbernardo]

I think trying to understand why that warning sign is there might help here.

[jaimecbernardo]

Oh, this is because it's a UWP project being referenced from a non UWP project. (different platforms), so I'm guessing this breaks the dependency graph somewhat and tries to build PowerRenameUIHost before PowerRenameUILib actually finished building, if this makes sense.

[jaimecbernardo]

This error occurs because all these projects use the same output directory. Sometimes, the start of the PowerRenameHost project cleans out the *.winmd files that are required to build it. Using a dedicated output folder for PowerRenameUILib and then copying the contents to PowerRenameHost output directory before building it seems to solve it.

[dend]

@jaimecbernardo should this be closed with the build change merged?

[jaimecbernardo]

@jaimecbernardo should this be closed with the build change merged?

We usually wait for release before going through the "Resolution-Fix-Committed" issues and close them.
Please let me know if you encounter it again.