Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Workspaces not showing up #16283

Closed
1 task
mkholt opened this issue Feb 11, 2022 · 24 comments
Closed
1 task

VS Code Workspaces not showing up #16283

mkholt opened this issue Feb 11, 2022 · 24 comments
Assignees
Labels
Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Things that relate with PowerToys Run's plugin interface

Comments

@mkholt
Copy link

mkholt commented Feb 11, 2022

Microsoft PowerToys version

0.55.1

Running as admin

  • Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

  1. Update VS Code to a version > 1.64
  2. Ensure Visual Studio Code Workspaces is enabled.
  3. Trigger PowerToys Run
  4. Search for a workspace by triggering (default: {)
  5. Notice that no workspaces show up
    image

✔️ Expected Behavior

A list of workspaces is shown

❌ Actual Behavior

Nothing is returned

Other Software

VS Code > 1.64

@mkholt mkholt added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 11, 2022
@franky920920
Copy link
Contributor

cc: @ricardosantos9521

@franky920920 franky920920 added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Things that relate with PowerToys Run's plugin interface labels Feb 13, 2022
@franky920920
Copy link
Contributor

Could you attach a full bug report file?
Right-click on the tray icon and click Report Bug. Then drag-and-drop the generated file into the GitHub comment to upload it. Thanks!
image

/needinfo

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 13, 2022
@mkholt
Copy link
Author

mkholt commented Feb 13, 2022

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 13, 2022
@ricardosantos9521
Copy link
Contributor

@mkholt can you try to exit powertoys and open it again? Also, close and open vscode. And if you can show me the workspaces that appear on your taskbar here
image

@suxscribe
Copy link

Same with VSCode 1.64 on Windows 10, PowerToys 0.55.2

@mkholt
Copy link
Author

mkholt commented Feb 13, 2022

@ricardosantos9521, problem seems to be resolved by exiting powertoys and vscode.
I could swear I had done that before.

Attached is screenshot anyway for completeness.
image

@ricardosantos9521
Copy link
Contributor

Same with VSCode 1.64 on Windows 10, PowerToys 0.55.2

@suxscribe can you try do the same

@suxscribe
Copy link

Same with VSCode 1.64 on Windows 10, PowerToys 0.55.2

@suxscribe can you try do the same

Exiting and reopening PowerToys helped, thank you!

@franky920920 franky920920 added Resolution-Helped User Could help the user by a problem they had and removed Needs-Team-Response An issue author responded so the team needs to follow up labels Feb 14, 2022
@crutkas
Copy link
Member

crutkas commented Feb 15, 2022

@ricardosantos9521 what caused it to need a restart?

@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Feb 15, 2022
@ziesemer
Copy link

Same issue here. Restarting PowerToys only (not VSCode) resolved it - and also curious as to why. The only thing that comes to mind is when it restarted from the 0.55.2 update, that it didn't initialize properly and needed the follow-up restart? (Looks like everyone here other than the OP is reporting being on the 0.55.2 version.)

@FWest98
Copy link
Contributor

FWest98 commented Feb 18, 2022

I just had this same issue - here too restarting solved it. I also noticed PT Run to be much snappier after the restart (before it would take seconds to load) - maybe that is related? Also on 0.55.2 here.

@mkholt
Copy link
Author

mkholt commented Feb 21, 2022

After updating to 0.55.2 the issue re-occured until restart of PowerToys.
Something is definitely not getting initialized properly.

@crutkas
Copy link
Member

crutkas commented Feb 26, 2022

@ricardosantos9521 any idea where the race condition could be?

@crutkas crutkas removed the Resolution-Helped User Could help the user by a problem they had label Feb 26, 2022
@ricardosantos9521
Copy link
Contributor

Yes @crutkas it could be the sqlitereader locking the file or something i will try to find sometimes to reproduce and fix the issue.

@ricardosantos9521
Copy link
Contributor

Hi all @crutkas sorry for being too late. I have time today and found the issue and a fixe for it.
There's no concurrency happening.
The issue is with the first time that powertoys is installed or after an updated for some reason the first time we get Environment.GetEnvironmentVariable("PATH") only the system environment variables are obtained and not the user environment variables.
I fixed the issue by including the user variables to. Will do a pull request.
Regards,
Ricardo Santos

@Aaron-Junker Aaron-Junker added the Status-In progress This issue or work-item is under development label Mar 26, 2022
@jaimecbernardo jaimecbernardo added this to To do in 0.58 Release via automation Apr 4, 2022
@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Apr 4, 2022
@jaimecbernardo jaimecbernardo moved this from To do to Done in 0.58 Release Apr 4, 2022
@sba923
Copy link

sba923 commented Apr 5, 2022

@ricardosantos9521 do you confirm that PowerToys Run VScode integration requires to have VScode on the PATH?

I don't, because I have an old habit not to add applications to the PATH at installation time, originally to speed up executable and DLL searches throughout the system, and also to make it easier to have multiple versions installed side-by-side (and choosing on a per-shell basis which one I want to use).

@ricardosantos9521
Copy link
Contributor

@ricardosantos9521 do you confirm that PowerToys Run VScode integration requires to have VScode on the PATH?

I don't, because I have an old habit not to add applications to the PATH at installation time, originally to speed up executable and DLL searches throughout the system, and also to make it easier to have multiple versions installed side-by-side (and choosing on a per-shell basis which one I want to use).

Yes vscode path must be in the environment variables. Ussually during the installation vscode does this.

@sba923
Copy link

sba923 commented Apr 5, 2022

Yes vscode path must be in the environment variables.

Thanks for the confirmation.

Usually during the installation vscode does this.

It doesn't if you uncheck the box. Which I do, for the reasons described earlier.

@sba923
Copy link

sba923 commented Apr 5, 2022

Yes vscode path must be in the environment variables.

Thanks for the confirmation.

Ussually during the installation vscode does this.

It doesn't if you uncheck the box. Which I do, for the reasons described earlier.

@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label Apr 6, 2022
@ziesemer
Copy link

ziesemer commented Apr 9, 2022

At least for me, this is now working after upgrade, as tested with the 0.57.2 update that was just released.

@Aaron-Junker
Copy link
Collaborator

This got implemented/fixed in the 0.58 update.

@marktoman
Copy link

BTW the required path is not the root directory, which contains code.exe, but the bin subdirectory.

@golxzn
Copy link

golxzn commented Dec 28, 2023

Hi. I'm on the version 0.76.2 and still have the same issue. PowerToys reloading doesn't help as well as PATH environment manipulations, like removing the ending / from the VSCode bin directory.

PowerToys opens neither workspaces nor directories. VSCode has 1.85.1 (user setup) version.
I've been dancing with this issue for a 2 month as well. It's with me since few updates of each app.

Here's the bug report: PowerToysReport_2023-12-28-07-06-20.zip

@TheColorman
Copy link

TheColorman commented Feb 6, 2024

Same issue that has been happening to me for a couple weeks now, VSCode insiders bin is on path, nothing shows up, I do have recent folders, all third partly plugins are disabled.
PowerToys v0.78.0.
Visual Studio Code - Insiders Version 1.87.0-insider (user setup).

Restarting neither PowerToys nor vscode does not fix the issue.

PowerToysReport_2024-02-06-21-24-10.zip

EDIT: Removing all "recently opened" in vscode seems to have fixed the issue? New folders I open now show up in PT Run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
No open projects
Development

No branches or pull requests