Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[installer] Lang folder for WindowsTerminal not active #16712

Closed
1 task
htcfreek opened this issue Mar 2, 2022 · 2 comments
Closed
1 task

[installer] Lang folder for WindowsTerminal not active #16712

htcfreek opened this issue Mar 2, 2022 · 2 comments
Assignees
@jaimecbernardo
Labels
Area-Setup/Install Refers to installation mechanism Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
0.57 Release

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Mar 2, 2022 •
edited
Loading

Microsoft PowerToys version

RC v0.57.0

Running as admin

  • Yes

Area(s) with issue?

Installer

Steps to reproduce

Found in Product.wxs:

            <!-- Uncomment after Plugin receives the localization files.
                <Component 
                    Id="Launcher_WindowsTerminal_$(var.IdSafeLanguage)_Component" 
                    Guid="$(var.CompGUIDPrefix)15"                
                    Directory="Resource$(var.IdSafeLanguage)WindowsTerminalFolder">
                    <File Id="Launcher_WindowsTerminal_$(var.IdSafeLanguage)_File" Source="$(var.BinX64Dir)modules\launcher\Plugins\WindowsTerminal\$(var.Language)\Microsoft.PowerToys.Run.Plugin.WindowsTerminal.resources.dll" />
                </Component>
                -->

✔️ Expected Behavior

No response

❌ Actual Behavior

No response

Other Software

No response
@htcfreek htcfreek added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Area-Setup/Install Refers to installation mechanism labels Mar 2, 2022
@htcfreek htcfreek changed the title [installer] Landfolder for WindowsTerminal not active [installer] Lang folder for WindowsTerminal not active Mar 3, 2022
@htcfreek
Copy link
Collaborator Author

htcfreek commented Mar 3, 2022

@jaimecbernardo
this can be integrated in the hotfix I think

@jaimecbernardo jaimecbernardo added Hot Fix Items we will product an out-of-band release for and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Mar 4, 2022
@jaimecbernardo jaimecbernardo added this to To do in 0.57 Release via automation Mar 4, 2022
@jaimecbernardo jaimecbernardo moved this from To do to In progress in 0.57 Release Mar 4, 2022
@jaimecbernardo jaimecbernardo self-assigned this Mar 4, 2022
@jaimecbernardo jaimecbernardo added the Status-In progress This issue or work-item is under development label Mar 4, 2022
This was referenced Mar 4, 2022
Merged
Merged
@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Mar 4, 2022
@jaimecbernardo jaimecbernardo moved this from In progress to Done in 0.57 Release Mar 4, 2022
@crutkas crutkas mentioned this issue Mar 8, 2022
Closed
@htcfreek
Copy link
Collaborator Author

htcfreek commented Apr 2, 2022

This is fixed with 0.57.0. Please head over to https://aka.ms/installpowertoys

@htcfreek htcfreek closed this as completed Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaimecbernardo jaimecbernardo

Labels
Area-Setup/Install Refers to installation mechanism Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
0.57 Release
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaimecbernardo @htcfreek