Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerToys Run search takes a long time #17454

Closed
1 task done
tfx2001 opened this issue Apr 2, 2022 · 19 comments
Closed
1 task done

PowerToys Run search takes a long time #17454

tfx2001 opened this issue Apr 2, 2022 · 19 comments
Assignees
Labels
Area-Quality Stability, Performance, Etc. Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Things that relate with PowerToys Run's plugin interface Status-Reproducible This issue was reproduced by a maintainer

Comments

@tfx2001
Copy link

tfx2001 commented Apr 2, 2022

Microsoft PowerToys version

0.57.0

Running as admin

  • Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

Use as usual, but the result show after a long time. By checking logs, it's shows spent a lots of time on System Commands plugin. After disable System Commands plugin, It's back to normal, but the cpu usage is very high when I was searching.

[2022-04-02 10:14:13.7841] [WARN] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::205]
PluginManager.QueryForPlugin System Commands. Query cost - 9415 milliseconds

[2022-04-02 10:14:13.8491] [WARN] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::205]
PluginManager.QueryForPlugin System Commands. Query cost - 9366 milliseconds

[2022-04-02 10:14:13.9037] [WARN] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::205]
PluginManager.QueryForPlugin System Commands. Query cost - 9379 milliseconds

[2022-04-02 10:14:14.0115] [WARN] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::205]
PluginManager.QueryForPlugin System Commands. Query cost - 9349 milliseconds

[2022-04-02 10:14:14.1515] [WARN] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::205]
PluginManager.QueryForPlugin System Commands. Query cost - 9220 milliseconds

✔️ Expected Behavior

Result show as quickly as before.

❌ Actual Behavior

It took about 8-9 seconds.

Other Software

No response

@tfx2001 tfx2001 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 2, 2022
@Brehpy
Copy link

Brehpy commented Apr 2, 2022

I have experienced the same issue in the past, but then it stopped working at all, whenever i try to type any character it freezes and then I have to manually end the task, I've deleted the "PowerToys Run" folder, disabbled the "run as admin" option and reinstalled the app many times and it's still not working!

I look forward for a solution for this(these) issues.

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 2, 2022

Thank you for reporting this. Can you both please give us more detailed information when this is happening?

/bugreport

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 2, 2022
@ghost
Copy link

ghost commented Apr 2, 2022

Hi there!

We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here? You right click on our system tray icon and just go to report bug. Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks!
Report Bug

@tfx2001
Copy link
Author

tfx2001 commented Apr 2, 2022

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 2, 2022
@Jay-o-Way Jay-o-Way added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Area-Quality Stability, Performance, Etc. Run-Plugin Things that relate with PowerToys Run's plugin interface labels Apr 2, 2022
@Brehpy
Copy link

Brehpy commented Apr 2, 2022

Thank you for reporting this. Can you both please give us more detailed information when this is happening?

/bugreport

Sure! Here it is:

PowerToysReport_2022-04-01-18-09-31.zip

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 2, 2022

@Brehpy, @tfx2001
Can you please do a quick test for me: Please disable the plugins "Programs" and "VS Code Workspace" and restart the PowerToys application.

Is the long query time gone after doing this?

@tfx2001
Copy link
Author

tfx2001 commented Apr 2, 2022

@Brehpy, @tfx2001 Can you please do a quick test for me: Please disable the plugins "Programs" and "VS Code Workspace" and restart the PowerToys application.

Is the long query time gone after doing this?

It still tasks a long time, but it's gone after disable "System Command".

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 2, 2022

@Brehpy, @tfx2001 Can you please do a quick test for me: Please disable the plugins "Programs" and "VS Code Workspace" and restart the PowerToys application.
Is the long query time gone after doing this?

It still tasks a long time, but it's gone after disable "System Command".

That we don't miss understood each other. This issue isn't new in v0.57.0?

@tfx2001
Copy link
Author

tfx2001 commented Apr 2, 2022

It is new in v0.57.0.

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 2, 2022

Do you have some special network adapters or many of them? /needinfo

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Apr 2, 2022
@htcfreek htcfreek added the Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. label Apr 2, 2022
@tfx2001
Copy link
Author

tfx2001 commented Apr 3, 2022

I‘m using Docker Desktop, and it creates many network adapters.

image

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 3, 2022
@htcfreek htcfreek removed Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 3, 2022
@htcfreek htcfreek added Status-Reproducible This issue was reproduced by a maintainer and removed Needs-Team-Response An issue author responded so the team needs to follow up labels Apr 3, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Apr 3, 2022

I can reproduce it and working on a fix. (For me the query times not as high as for you but they are high).

@htcfreek htcfreek added Status-In progress This issue or work-item is under development Priority-1 Bug that is high priority labels Apr 3, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Apr 3, 2022

@jaimecbernardo
I think this should be a hotfix because users with many net adapters (e.g. for docker containers) can't use PT Run without disabling the plugin.

@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label Apr 4, 2022
@jaimecbernardo
Copy link
Collaborator

Sounds like a hotfix candidate indeed.

@jaimecbernardo
Copy link
Collaborator

Hi @tfx2001 ,

Could you please try a debug build with the fix so we can validate it on your configuration? (It's an unsigned build , by the way)
https://github.com/jaimecbernardo/PowerToys/releases/tag/v0.0.1-test-pr-17490

Please uninstall your current PowerToys installation, then install this debug build.
Replicate the bug, to see if it's still there or if the behavior is better.

Please do it soon so we can validate and include in a hotfix.
Thank you, in advance.

@tfx2001
Copy link
Author

tfx2001 commented Apr 4, 2022

@jaimecbernardo @htcfreek Looks like it has been fixed and work well as before. Thanks for your efforts!

Here is the log: https://gist.github.com/tfx2001/683e31db0edc8aa804931f7217423510

@jaimecbernardo
Copy link
Collaborator

Thank you for validating!

@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Apr 4, 2022
@tfx2001 tfx2001 closed this as completed Apr 4, 2022
@jaimecbernardo jaimecbernardo reopened this Apr 4, 2022
@jaimecbernardo
Copy link
Collaborator

Letting this open until we do the release. Thank you.

@htcfreek htcfreek self-assigned this Apr 4, 2022
@wzajchow wzajchow mentioned this issue Apr 11, 2022
1 task
@htcfreek
Copy link
Collaborator

htcfreek commented May 4, 2022

Shipped with 0.58.0 (Hotfix for 0.57.2)

@htcfreek htcfreek closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Quality Stability, Performance, Etc. Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Things that relate with PowerToys Run's plugin interface Status-Reproducible This issue was reproduced by a maintainer
Projects
None yet
Development

No branches or pull requests

5 participants