Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PowerRename] Notify user when invalid character is used for renaming #17766

Closed
stefansjfw opened this issue Apr 15, 2022 · 3 comments
Closed

[PowerRename] Notify user when invalid character is used for renaming #17766

stefansjfw opened this issue Apr 15, 2022 · 3 comments
Assignees
@stefansjfw
Labels
Idea-Enhancement New feature or request on an existing product Priority-3 Bug that is low priority Product-PowerRename Refers to the PowerRename PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@stefansjfw
Copy link
Collaborator

Description of the new feature / enhancement

Ref: #17654

Dialog shown when user tries to rename using invalid character is not clear enough why renaming can't be done. So, some additional dialog in PowerRename could be shown to make the error more clear

Scenario when this would be used?

..

Supporting information

No response
@stefansjfw stefansjfw added Idea-Enhancement New feature or request on an existing product Product-PowerRename Refers to the PowerRename PowerToy Priority-3 Bug that is low priority labels Apr 15, 2022
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Apr 15, 2022
@stefansjfw stefansjfw mentioned this issue Apr 15, 2022
Closed
1 task
@niels9001
Copy link
Contributor

@stefansjfw We could do data validation in the input textbox and display a message while disabling the rename button, right?

@stefansjfw
Copy link
Collaborator Author

@stefansjfw We could do data validation in the input textbox and display a message while disabling the rename button, right?

Sure, that's what I had in mind as well.. This is not a big work item. Shouldn't take much time

@Jay-o-Way
Copy link
Collaborator

#4174
Touching #1853 and #8748 (comment)

@stefansjfw stefansjfw self-assigned this Apr 21, 2022
@Jay-o-Way Jay-o-Way mentioned this issue Jun 15, 2022
Closed
1 task
@stefansjfw stefansjfw removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jun 20, 2022
@stefansjfw stefansjfw mentioned this issue Aug 16, 2022
Merged
11 tasks
@Jay-o-Way Jay-o-Way added Status-In progress This issue or work-item is under development In progress labels Aug 16, 2022
@stefansjfw stefansjfw added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefansjfw stefansjfw

Labels
Idea-Enhancement New feature or request on an existing product Priority-3 Bug that is low priority Product-PowerRename Refers to the PowerRename PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crutkas @niels9001 @stefansjfw @Jay-o-Way