Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerRename silently fails to rename files with a path longer than 259 characters #18837

Closed
1 task done
helpimnotdrowning opened this issue Jun 14, 2022 · 3 comments
Closed
1 task done
Assignees
Labels
Issue-Bug Something isn't working Product-PowerRename Refers to the PowerRename PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@helpimnotdrowning
Copy link

Microsoft PowerToys version

0.59.0

Running as admin

  • Yes

Area(s) with issue?

PowerRename

Steps to reproduce

  1. Have a file with a full file path longer than 259 characters (mine was W:\URUHA RUSHIA CH - ARCHIVE\Rushia Ch. 潤羽るしあ\20220202 - 【Getting Over It with】ごめんあさい!壺おじ!!クリアしたいの!!応援してくだちい;;(未クリア)【潤羽るしあ_ホロライブ】\Rushia Ch. 潤羽るしあ - 20220202 - 【Getting Over It with】ごめんあさい!壺おじ!!クリアしたいの!!応援してくだちい;;(未クリア)【潤羽るしあ_ホロライブ】 [beHrlSK5kr0] f251.info.json (was multiple files, extensions were description,info.json)) on an external NTFS drive

  2. Use PowerRename to change the filename while keeping it above 259 characters (mine was
    image )

  3. No error message or warning is thrown, PowerRename just silently fails to rename the file

✔️ Expected Behavior

PowerRename to either rename the file (Registry key HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem\LongPathsEnabled is 1) or to fail to rename it, throwing me a warning.

❌ Actual Behavior

PowerRename silently fails to rename the file
(on a side note, the windows Explorer also doesn't let me add any characters after the path exceeds 259 characters, only letting me remove them until it goes back down)

Other Software

No response

@helpimnotdrowning helpimnotdrowning added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jun 14, 2022
@helpimnotdrowning
Copy link
Author

Addition: Choosing a list of files where even one has a path longer than 259 results in none of the files showing up in PowerRename

One file, path < 260:
image

One file, path > 260:
image

Multiple files, one with a path > 260:
image

This can be worked around by opening PowerRename on the parent folder, like I did in the original post/

@helpimnotdrowning helpimnotdrowning changed the title PowerRename gives no warning or error when failing to rename a file with a path longer than 259 characters PowerRename silently fails to rename files with a path longer than 259 characters Jun 14, 2022
@Jay-o-Way Jay-o-Way added the Product-PowerRename Refers to the PowerRename PowerToy label Jun 15, 2022
@Jay-o-Way
Copy link
Collaborator

Good point. Similar to #8748.
Also (loosely) related #1853 and #17766

@stefansjfw stefansjfw self-assigned this Jun 20, 2022
@stefansjfw
Copy link
Collaborator

thanks for the report, I'll take a look into this

@stefansjfw stefansjfw removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jun 20, 2022
@Jay-o-Way Jay-o-Way added Status-In progress This issue or work-item is under development In progress labels Aug 16, 2022
@stefansjfw stefansjfw added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Product-PowerRename Refers to the PowerRename PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

4 participants