Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Registry Preview] More menu transparent #25253

Closed
htcfreek opened this issue Apr 6, 2023 · 6 comments
Closed

[Registry Preview] More menu transparent #25253

htcfreek opened this issue Apr 6, 2023 · 6 comments
Assignees
@jaimecbernardo
Labels
Area-User Interface things that regard UX for PowerToys Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-Registry Preview Refers to the Registry Preview PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
0.70 Release

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 6, 2023 •
edited

Microsoft PowerToys version

0.69.0

Installation method

GitHub, PowerToys auto-update

Running as admin

No

Area(s) with issue?

Registry Preview

Steps to reproduce

Open Registry Preview from context menu.

Operating System: Windows 10 22H2

✔️ Expected Behavior

More menu in menu bar has background color.

❌ Actual Behavior

image

Other Software

No response
@htcfreek htcfreek added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Registry Preview Refers to the Registry Preview PowerToy labels Apr 6, 2023
@stefansjfw stefansjfw removed the Priority-0 Bugs that we consider release-blocking/recall-class (P0) label Apr 6, 2023
@htcfreek htcfreek changed the title [Registry Preview] Menubar more menu transparrent [Registry Preview] More menu transparent Apr 6, 2023
@htcfreek htcfreek added the Area-User Interface things that regard UX for PowerToys label Apr 6, 2023
@stefansjfw stefansjfw mentioned this issue Apr 6, 2023
Closed
@randyrants randyrants mentioned this issue Apr 7, 2023
Merged
1 task
@htcfreek htcfreek added Status-In progress This issue or work-item is under development and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 7, 2023
@Jay-o-Way
Copy link
Collaborator

To be specific: Not just those in the "more" menu
image

@randyrants
Copy link
Collaborator

randyrants commented Apr 10, 2023 •
edited

I think the change to an opaque background would catch this too, since it looks like any "floating" overlay uses the same color setting as the main bar, which is interesting. Could also be the Mica rendering getting a little overexcited in its application. I couldn't track that part down, so I just flipped on a color, and I couldn't repro the original issue.

@htcfreek
Copy link
Collaborator Author

htcfreek commented Apr 10, 2023 •
edited

and I couldn't repro the original issue.

Maybe it only happens on Windows 10 with dark theme. 🤔 When reviewing your initial PR I didn't see this bug.

@htcfreek
Copy link
Collaborator Author

htcfreek commented Apr 11, 2023 •
edited

@jaimecbernardo
Can we hotfix this too. It has impact on usability for users with disabilities.

@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label Apr 11, 2023
@jaimecbernardo
Copy link
Collaborator

@jaimecbernardo Can we hotfix this too. It has impact on usability for users with disabilities.

@htcfreek, The PR was as hotfix already, I've set the issues as well. Thanks for pointing it out.

@jaimecbernardo jaimecbernardo self-assigned this Apr 12, 2023
@jaimecbernardo
Copy link
Collaborator

This is actually being caused by the missing "Microsoft.UI.Xaml\Assets\NoiseAsset_256x256_PNG.png" file in the installer.
Will add a fix for this.

@jaimecbernardo jaimecbernardo mentioned this issue Apr 12, 2023
Merged
11 tasks
@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Apr 12, 2023
@jaimecbernardo jaimecbernardo added this to To do in 0.70 Release via automation Apr 12, 2023
@jaimecbernardo jaimecbernardo moved this from To do to Done in 0.70 Release Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaimecbernardo jaimecbernardo

Labels
Area-User Interface things that regard UX for PowerToys Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-Registry Preview Refers to the Registry Preview PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
Test for PowerToys
Status: Done ✔
0.70 Release
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@randyrants @jaimecbernardo @stefansjfw @htcfreek @Jay-o-Way