[Registry Preview] Fixes in for the command bar in XAML #25266
Merged
+28
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the toolbar to have a color, rather than transparent Added radial corners to the textbox and gridview.
Changing short cuts for Save and Save As
randyrants
changed the title
A wise engineer once said "save the file, fool, before committing it to the repro."
|
Why is |
|
Jay-o-Way
reviewed
Apr 8, 2023
| @@ -209,6 +226,7 @@ | |||
| Grid.RowSpan="2" | |||
| Grid.Column="2" | |||
There was a problem hiding this comment.
RowSpan="2" should be oblsolete now, am I right?
Comment on lines
57
to
58
| BorderBrush="Transparent" | ||
| BorderThickness="0" |
There was a problem hiding this comment.
Why declare these in the first place? :)
jaimecbernardo
added
the
Hot Fix
SeraphimaZykova
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Referenced problems for that PR seems to be fixed, but changes @Jay-o-Way proposed also make sense. So I believe we can merge it but open an issue with those comments, so they don't get lost later.
|
@SeraphimaZykova Going to merge this in to avoid conflicts, will address the mentioned comments with a PR to fix: #25406 |
BLM16
pushed a commit
to BLM16/PowerToys
that referenced
this pull request
Jun 22, 2023
) * Update MainWindow.xaml Change the toolbar to have a color, rather than transparent Added radial corners to the textbox and gridview. * Update MainWindow.xaml Changing short cuts for Save and Save As * Update MainWindow.xaml A wise engineer once said "save the file, fool, before committing it to the repro." * Moved to FontIcons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
XAML fixes for the transparency on the command bar and unified radial corners.
Changes shortcuts for Save and Save As buttons.
Moved to FontIcon for icon which should work on systems that don't have the specific Symbol font. Also picks up support for the original icon that was required for Edit 😄
PR Checklist
Detailed Description of the Pull Request / Additional comments
Changed the background property for the command bar from transparent to one of the theme brushes, so that the overflow from the ... button had an opaque background.
Also added radial corner settings to the TextBox and the DataGrid, to match the rest of the UX, changed the keyboard accelerators for Save and Save As to be more "normal" and updated the method used to show an icon.
Validation Steps Performed
Ran the window several times in different sizes as well as in light and dark theme modes.