Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Peek; Dev files preview] Support .inf files #26135

Closed
htcfreek opened this issue May 23, 2023 · 8 comments
Closed

[Peek; Dev files preview] Support .inf files #26135

htcfreek opened this issue May 23, 2023 · 8 comments
Assignees
@Aaron-Junker
Labels
Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
0.71 Release

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented May 23, 2023 •
edited

Description of the new feature / enhancement

Add support for .inf files.

This can use the same syntax as .ini files.

Scenario when this would be used?

When previewing inf file from drivers or our software deployment system.

Supporting information

No response
@htcfreek htcfreek added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane labels May 23, 2023
@htcfreek
Copy link
Collaborator Author

htcfreek commented May 26, 2023 •
edited

@Aaron-Junker
Do I only have to update languages.json manually for this?

@Aaron-Junker
Copy link
Collaborator

@Aaron-Junker
Do I only have to update languages.json manually for this?

No. You have to add a line like this one: https://github.com/microsoft/PowerToys/blob/main/src/common/FilePreviewCommon/monacoSpecialLanguages.js#L7

And then regenerate monaco_languages.json as descrived in the devdocs

@Aaron-Junker
Copy link
Collaborator

xref: #24322

@crutkas
Copy link
Member

crutkas commented May 26, 2023

Shouldn’t this be pretty straightforward to add in?

@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label May 26, 2023
@Aaron-Junker
Copy link
Collaborator

Shouldn’t this be pretty straightforward to add in?

Yes. Would take about 5 minutes

@Aaron-Junker
Copy link
Collaborator

I'll do it pretty quick

@Aaron-Junker Aaron-Junker self-assigned this May 26, 2023
@Aaron-Junker Aaron-Junker added the Status-In progress This issue or work-item is under development label May 26, 2023
@Aaron-Junker Aaron-Junker mentioned this issue May 26, 2023
Merged
11 tasks
@htcfreek
Copy link
Collaborator Author

Amazing. ❤️

@crutkas crutkas added this to To do in 0.71 Release via automation May 30, 2023
@crutkas crutkas added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels May 30, 2023
@jaimecbernardo jaimecbernardo moved this from To do to Done in 0.71 Release May 30, 2023
@crutkas
Copy link
Member

crutkas commented Jul 14, 2023

Fixed in 0.71 release of PowerToys. aka.ms/installpowertoys

@crutkas crutkas closed this as completed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aaron-Junker Aaron-Junker

Labels
Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
0.71 Release
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crutkas @Aaron-Junker @htcfreek and others