Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monaco] Add vbs and certain ini compatible file extensions #26373

Merged
merged 3 commits into from May 29, 2023

Conversation

Aaron-Junker
Copy link
Collaborator

@Aaron-Junker Aaron-Junker commented May 26, 2023

Summary of the Pull Request

Add vbs and the following ini compatible estensions:

  • inf
  • gitconfig
  • gitattributes
  • editorconfig

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@Aaron-Junker Aaron-Junker changed the title [Monaco] Add vbs and inf file extensions [Monaco] Add vbs and certain ini compatible file extensions May 26, 2023
@@ -10,6 +10,8 @@ export async function registerAdditionalLanguages(monaco){
registerAdditionalLanguage("txtExt", [".sln"], "txt", monaco)
registerAdditionalLanguage("razorExt", [".razor"], "razor", monaco)
registerAdditionalLanguage("logExt", [".log"], "log", monaco)
registerAdditionalLanguage("vbExt", [".vbs"], "vb", monaco)
registerAdditionalLanguage("iniExt", [".inf", ".gitconfig", ".gitattributes", ".editorconfig"], "ini", monaco)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe .gitignore can be supported here as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No .gitignore uses a completly different syntax. And I added that in another PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I forgot about that PR. I even approved it already :P

@jaimecbernardo jaimecbernardo merged commit d7ff0d0 into main May 29, 2023
10 checks passed
@crutkas crutkas deleted the dev/aaron-junker/inf-files branch June 1, 2023 03:48
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
…#26373)

* [Monaco] Add vbs and inf file extensions

* Add githconfig, gitattributes, editorconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants