Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peek memory leak/does not clear memory after closing the window and after reaching a limit #26162

Closed
nitzukai opened this issue May 23, 2023 · 7 comments
Assignees
Labels
Issue-Bug Something isn't working Product-Peek Refers to Peek Powertoys Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@nitzukai
Copy link

Microsoft PowerToys version

0.70.0

Installation method

WinGet

Running as admin

No

Area(s) with issue?

Peek

Steps to reproduce

1- Turn on Peek
2- Open Task Manager and watch the memory usage of Peek's process
3- Preview a few images, files etc. from the File Explorer
4- Watch the memory usage of Peek even reach 1000 MBs as you preview more images and files.

✔️ Expected Behavior

I expected it to not use so much memory, clear its memory after closing the preview window and have a soft limit to its memory usage

❌ Actual Behavior

It reached really high and unreasonable numbers of memory usage after previewing some images and files.

Other Software

No response

@nitzukai nitzukai added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels May 23, 2023
@htcfreek htcfreek added the Product-Peek Refers to Peek Powertoys label May 23, 2023
@htcfreek
Copy link
Collaborator

@SamChaps for your information.

@htcfreek
Copy link
Collaborator

/bugreport

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels May 23, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hi there!

We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here? You right click on our system tray icon and just go to report bug. Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks!
Report Bug

@Smeagol2069
Copy link

I am unable to reproduce this. I have tried several different folders of images and videos, but the highest memory usage was about 500 mb. Averaging around 300 mb.

Powertoys 0.70.0

@fndrsm
Copy link

fndrsm commented May 24, 2023

On my laptop, it cause CPU high usage. I opened an issue here. #26176

@nitzukai
Copy link
Author

nitzukai commented May 24, 2023

Okay so I was looking around the log files of all the Powertoys apps and Peek is the only one that has Error messages in its log file. Is it okay if it only share the Peek's log file?
Peek.zip

My basic system configuration if its necessary information:
Windows 11 Pro build 22621.1702
i7 11800H
16 GB DDR4 RAM
NVMe SSD

The UI process reaches even 4 GB of usage after previewing high resolution images and going through them by holding down the left or right arrow keys. It then randomly drops back to like 500-600 MB after previewing another file in a different folder. Even if I don't go through images by holding down the keys, opening a few high resolution (like 4K or higher) images is mostly enough for it to reach 1 GB.
image

I tried reinstalling multiple times from different sources (installer downloaded from the official site, Winget, MS Store), deleting all of Powertoys' data files and making sure it's as close to a fresh install, turning off all the other apps of Powertoys except Peek and even tried to reinstall WebView2 but none of them seemed to make a difference. Not sure why its not reproduceable on other systems but I hope it could get resolved somehow because this was a feature that I was really excited for because even though apps like Quick Look exists I am sure that Powertoys team can make a more native feeling and lightweight one.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 24, 2023
@SeraphimaZykova SeraphimaZykova self-assigned this May 25, 2023
@SeraphimaZykova SeraphimaZykova added Status-In progress This issue or work-item is under development and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels May 25, 2023
@SeraphimaZykova SeraphimaZykova added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels May 30, 2023
@jaimecbernardo jaimecbernardo added this to To do in 0.71 Release via automation May 30, 2023
@jaimecbernardo jaimecbernardo moved this from To do to Done in 0.71 Release May 30, 2023
@crutkas
Copy link
Member

crutkas commented Jul 14, 2023

Fixed in 0.71 release of PowerToys. aka.ms/installpowertoys

@crutkas crutkas closed this as completed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Product-Peek Refers to Peek Powertoys Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
Development

No branches or pull requests

6 participants