Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Peek] Clear thumbnails #26440

Merged
merged 1 commit into from May 30, 2023
Merged

[Peek] Clear thumbnails #26440

merged 1 commit into from May 30, 2023

Conversation

SeraphimaZykova
Copy link
Collaborator

Summary of the Pull Request

Clear thumbnail memory.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

stefansjfw
stefansjfw approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce high memory usage (>700MB), so it doesn't make big difference on my end. Code looks good.

@stefansjfw
Copy link
Collaborator

I did some more testing , it doesn't go above 500MB now (comparing to ~700MB on main). So there is an improvement for sure

@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label May 29, 2023
@jaimecbernardo jaimecbernardo merged commit 9786d08 into main May 30, 2023
10 checks passed
@SeraphimaZykova SeraphimaZykova deleted the seraphima/peek-memleak branch May 30, 2023 09:01
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
@SeraphimaZykova @BLM16
[Peek]Clear thumbnails (microsoft#26440)
9cd33a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamChaps SamChaps SamChaps approved these changes

@stefansjfw stefansjfw stefansjfw approved these changes

@jaimecbernardo jaimecbernardo Awaiting requested review from jaimecbernardo

Assignees
No one assigned
Labels
Hot Fix Items we will product an out-of-band release for
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SeraphimaZykova @stefansjfw @SamChaps @jaimecbernardo