Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run] Remove tlpimp-Microsoft.Search.Interop nuget package from the Wox project #4475

Closed
alekhyareddy28 opened this issue Jun 24, 2020 · 5 comments
Labels
Area-Quality Stability, Performance, Etc. Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down) Priority-3 Bug that is low priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Milestone

Comments

@alekhyareddy28
Copy link
Contributor

Actual behavior

  • The tlbimp-Microsoft.Search.Interop nuget package is used by the Microsoft.Plugin.Indexer project. However, right now the nuget package is also being added to the Wox.csproj file because in .NET Core, the dlls are not automatically created. Rather they are only referred to in the .deps.json dependency file.

Expected behavior

The nuget package must only be added to the plugin project and not the wox project file.

@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jun 24, 2020
@crutkas crutkas added the Area-Quality Stability, Performance, Etc. label Jun 24, 2020
@crutkas crutkas added Cost-Small Small work item - 0-8 hours of work Product-PowerToys Run Improved app launch PT Run (Win+R) Window and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jun 24, 2020
@crutkas
Copy link
Member

crutkas commented Jun 24, 2020

@saahmedm any objection for 2007 milestone for launcher?

@crutkas crutkas added this to the InVEST-2009 milestone Aug 26, 2020
@dsrivastavv dsrivastavv self-assigned this Sep 3, 2020
@saahmedm saahmedm added the Priority-3 Bug that is low priority label Sep 11, 2020
@mykhailopylyp mykhailopylyp added the Status-In progress This issue or work-item is under development label Dec 1, 2020
@mykhailopylyp
Copy link
Contributor

@enricogior @crutkas
It is not so trivial to delete that reference. We load plugins without their dependencies at runtime.

var assembly = AssemblyLoadContext.Default.LoadFromAssemblyPath(metadata.ExecuteFilePath);

And because these dependencies are added to PowerLauncher.csproj, Launcher does not fail during runtime.

Basically, we need a solution that would load assemblies with their dependencies. Here is an example of how it can be done. They propose to load a plugin with its dependency into a separate context. So we will have some libraries loaded several times. I am not sure it can be easily accomplished with AssemblyLoadContext.Default. It seems like loading plugins with dependencies into separate contexts is required if we want to allow a user to write their own custom plugins.
Should we proceed with it?

@enricogior
Copy link
Contributor

@mykhailopylyp
I think this is a very low priority and we can postpone it.

@mykhailopylyp mykhailopylyp removed the Status-In progress This issue or work-item is under development label Dec 3, 2020
@enricogior enricogior added Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down) and removed Cost-Small Small work item - 0-8 hours of work labels Dec 10, 2020
@enricogior enricogior changed the title Remove tlpimp-Microsoft.Search.Interop nuget package from the Wox project [Run] Remove tlpimp-Microsoft.Search.Interop nuget package from the Wox project Jan 9, 2021
@crutkas
Copy link
Member

crutkas commented Dec 23, 2022

@snickler didnt we do this with the .net upgrade?

@snickler
Copy link
Collaborator

@snickler didnt we do this with the .net upgrade?

That is correct. We did this during the NET 6 upgrade.

@crutkas crutkas closed this as completed Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Quality Stability, Performance, Etc. Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down) Priority-3 Bug that is low priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Projects
None yet
Development

No branches or pull requests

7 participants