Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones] Place log files in subfolders with the version number. #10549

Merged
merged 5 commits into from Apr 7, 2021

Conversation

SeraphimaZykova
Copy link
Collaborator

Summary of the Pull Request

What is this about:

Create a subfolder with the version number for logs, e.g. PowerToys\FancyZones\Logs\v0.35.0.
Delete old logs in PowerToys\FancyZones\FancyZonesLogs and logs in subfolders with different versions.

What is include in the PR:

How does someone test / validate:

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@SeraphimaZykova SeraphimaZykova added Area-Logging Issues regarding the PowerToys logging facility Product-FancyZones Refers to the FancyZones PowerToy labels Apr 2, 2021
@mykhailopylyp
Copy link
Contributor

What are the reasons behind introducing logger_helper.h?
It should be at least included in the logger project. But I think we don't need a dedicated file for that, all functionality can be added to existing files in the logger project.
We should create a dedicated init method for fancy zones and then switch all modules to it.

@SeraphimaZykova
Copy link
Collaborator Author

What are the reasons behind introducing logger_helper.h?
It should be at least included in the logger project. But I think we don't need a dedicated file for that, all functionality can be added to existing files in the logger project.
We should create a dedicated init method for fancy zones and then switch all modules to it.

If we move helper functions to the logger project, it would be dependant on the common/version, that's not worth it.

@mykhailopylyp
Copy link
Contributor

SG: Define function init_logger(wstring app_key, wstring logger_name) in logger_helper.h that will delete other version logs as well as call Logger::init. And it would be reused in each module.

Copy link
Contributor

@mykhailopylyp mykhailopylyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Tested, works as expected.

Copy link
Contributor

@enricogior enricogior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, worked as expected. Nice work.

@SeraphimaZykova SeraphimaZykova merged commit 55a851e into microsoft:master Apr 7, 2021
@SeraphimaZykova SeraphimaZykova deleted the 10540-fz-logs branch April 7, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Logging Issues regarding the PowerToys logging facility Product-FancyZones Refers to the FancyZones PowerToy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants