Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding KeyManager spec #1107

Closed
wants to merge 0 commits into from
Closed

Adding KeyManager spec #1107

wants to merge 0 commits into from

Conversation

saahmedm
Copy link
Contributor

Summary of the Pull Request

This pull request is adding the functional spec for the Keyboard Manager.

Changes:

  • Added the KeyManager.md in the spec folder
  • Added the images from the spec in a new folder in the image folder in doc/specs/images
  • Updated the readme.MD in images to include link to KeyManager.md

References

N/A

PR Checklist

  • Applies to Keyboard shortcut manager #6
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

N/A

@saahmedm saahmedm requested a review from crutkas January 17, 2020 00:38
@bzoz
Copy link
Contributor

bzoz commented Jan 17, 2020

We have two primary customers:

- **Developers/PowerUsers** of Windows10 that want a built-in and lightweight solution to remap their own hotkeys which will increase their efficiency in completing tasks.
- **Former MacOS** users who now use Windows and would like to utilize their former keyboard shortcuts to get rid of the learning period and ease the transition to using a new device.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would also add in Linux users. This then ties into having a Linux profile too

| 3 | App level keyboard shortcuts. Example: Going to the address bar in Chrome on a MacOS is CMD+L, on a PC, that would map to Alt-L. | P2 |
| 4 | Settings page that easily configures all supported scenarios. | P1 |
| 5 | The Powertoys Shortcut Guide needs to be aware of keyboard remaps. Example: If Winkey + G locks the computer the Shortcut Guide needs to list this as the method to lock a computer, not Winkey + L. | P1 |
| 6 | A Mac and Linux ready profile that is prepopulated with commonly used remaps and adjustments. | P1 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would break these into separate items. Explicitly calling out Mac and Linux as i bet they will be different work items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants