Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse Utils - Inclusive Mouse #15633

Merged
merged 31 commits into from Jan 24, 2022
Merged

Mouse Utils - Inclusive Mouse #15633

merged 31 commits into from Jan 24, 2022

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

What is this about:
Adds a new PowerToy called "Inclusive Mouse", under "Mouse Utilities".
This PowerToys draws a crosshair around the mouse pointer in its current screen, target at a set of users with specific accessibility needs.
This PowerToy has been designed originally by the accessibility team.
Default activation key is Ctrl+Alt+P.

image

What is included in the PR:

  • The code for the PowerToys.
  • Settings page and Oobe description line.
  • Logging and telemetry.

image

How does someone test / validate:
Start PowerToys with the module enabled and press "Ctrl"+"Alt"+"P". Move the mouse around and check it has a crosshair following it "Ctrl"+"Alt"+"P" to toggle it off again.

Quality Checklist

  • Linked issue: Mouse Utility - Crosshair mouse #15632
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@crutkas
Copy link
Member

crutkas commented Jan 19, 2022

Trying to hand a build off to accessibility, possible to get fixes needed to get signing back on rebased on here?

@htcfreek
Copy link
Collaborator

@jaimecbernardo
On the oobe screenshot cursor isn't centered between the red lines. Is this a bug?

@jaimecbernardo
Copy link
Collaborator Author

@htcfreek , it's not a bug, it's as in the original internal design doc from the accessibility team.
It's centered around the point the mouse pointer is pointing to.

@crutkas
Copy link
Member

crutkas commented Jan 19, 2022

Feedback: Off by default.

@crutkas
Copy link
Member

crutkas commented Jan 20, 2022

One feedback was restricting width and border. If someone has it too high. It blocks everything. Thought was like 50 max

@jaimecbernardo
Copy link
Collaborator Author

One feedback was restricting width and border. If someone has it too high. It blocks everything. Thought was like 50 max

Added a maximum of 50 for the thickness and border size.

@htcfreek
Copy link
Collaborator

One feedback was restricting width and border. If someone has it too high. It blocks everything. Thought was like 50 max

Added a maximum of 50 for the thickness and border size.

Does minimum of 1 make sense? It will be invisible I think.

@jaimecbernardo
Copy link
Collaborator Author

jaimecbernardo commented Jan 20, 2022

One feedback was restricting width and border. If someone has it too high. It blocks everything. Thought was like 50 max

Added a maximum of 50 for the thickness and border size.

Does minimum of 1 make sense? It will be invisible I think.

Actually, I meant for the border size to have a minimum of 0.
Thickness is OK to have the minimum of 1. It's a straight 1 pixel-width line. Just tested it, it's still seen.

@stefansjfw
Copy link
Collaborator

what about upper limit for radius ? Doesn't make sense to set it to 10000 and make in invisible.

@jaimecbernardo
Copy link
Collaborator Author

what about upper limit for radius ? Doesn't make sense to set it to 10000 and make in invisible.

There are some big screens, but I guess a 500 limit wouldn't be outrageous.

@htcfreek
Copy link
Collaborator

@jaimecbernardo , @niels9001
Not sure if this is possible. But with the min/max value thing a realistic (respecting dpi and scaling) preview might be helpful.

@jaimecbernardo
Copy link
Collaborator Author

@jaimecbernardo , @niels9001 Not sure if this is possible. But with the min/max value thing a realistic (respecting dpi and scaling) preview might be helpful.

I think these is one of those things where we can let users pick weird settings if they want. What we don't want is for them to inadvertently block their whole screen and lose all visibility and not understand what happened ;)

@jaimecbernardo
Copy link
Collaborator Author

@htcfreek , Here's an idea of some big values being used. Max thickness/border in this case:

image

@crutkas
Copy link
Member

crutkas commented Jan 21, 2022

I think we may want to just call this "Mouse pointer crosshairs" or something. Current name isn't really descriptive. We can adjust this before RTM but just calling it out.

@crutkas
Copy link
Member

crutkas commented Jan 24, 2022

Pass name tweak, what else is needed

@jaimecbernardo
Copy link
Collaborator Author

Other than name tweak, everything is here.
Perhaps a different icon for settings, but it can be changed in a further PR.

@niels9001
Copy link
Contributor

Other than name tweak, everything is here. Perhaps a different icon for settings, but it can be changed in a further PR.

Yeah, working on that.. I'll PR that in once this PR is merged.

@jaimecbernardo
Copy link
Collaborator Author

Other than name tweak, everything is here. Perhaps a different icon for settings, but it can be changed in a further PR.

Yeah, working on that.. I'll PR that in once this PR is merged.

Thanks a lot, Niels :)

@jaimecbernardo
Copy link
Collaborator Author

Just renamed the PowerToy to "Mouse Pointer Crosshair".
I'll merge this in as soon as CI passes.

image
image

@htcfreek
Copy link
Collaborator

Is Ctrl+Alt+Shift+P the default shortcut? Three modifier keys are a bit complicated to type.

@jaimecbernardo
Copy link
Collaborator Author

Is Ctrl+Alt+Shift+P the default shortcut? Three modifier keys are a bit complicated to type.

No, It's Ctrl+Alt+P. Those were my tests after the name change to make sure everything was working :)

@jaimecbernardo jaimecbernardo merged commit 2e8dfa7 into main Jan 24, 2022
@sntgchns
Copy link

Great addon! TNX!

@crutkas crutkas deleted the feature/inclusive-mouse branch January 31, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants