[OOBE]Not showing Welcome page after install #16561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansjfw
approved these changes
Feb 24, 2022
mshtang
pushed a commit
to mshtang/PowerToys
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
After #15920, PowerToys is not showing OOBE Welcome page after install. The reason for this is that it saves that it called OOBE before actually restarting as not elevated.
What is included in the PR:
Only save that oobe was called if the call to open oobe is called inside runner.
How does someone test / validate:
Uninstall Powertoys, delete %localappdata%\Microsoft\PowerToys, install PowerToys built from this branch and verify the OOBE opens in the Welcome page.
Quality Checklist