Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UpdateUtils): Allow disabling update checker #20510

Closed
wants to merge 1 commit into from

Conversation

xmine64
Copy link

@xmine64 xmine64 commented Sep 12, 2022

Summary of the Pull Request

This PR adds an option to disable auto update checker to settings UI.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@yuyoyuppe
Copy link
Collaborator

yuyoyuppe commented Sep 12, 2022

Thanks for the contribution. However, we intentionally do not introduce this feature, because that helps us track and solve issues more efficiently.

@crutkas thoughts?

@htcfreek
Copy link
Collaborator

@yuyoyuppe
See #2701 for discussion.

@xmine64
Copy link
Author

xmine64 commented Sep 12, 2022

we intentionally do not introduce this feature

Thanks for your response, but I would like to be able do that. I prefer updating things manually and the update notification is annoying. I know I can disable the notification from Windows settings but still it's a dirty work, also it still sends web request to check if update is available or not. I don't like this behavior.

@jaimecbernardo
Copy link
Collaborator

We'll be adding a deferral as part of the Group Policy Objects work.

@yuyoyuppe yuyoyuppe closed this Sep 13, 2022
@yuyoyuppe
Copy link
Collaborator

yuyoyuppe commented Sep 13, 2022

Closing it in favour of GPO effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants