-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPO] Fix the admx file by removing obsolete using #21813
Conversation
@jaimecbernardo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm OK with the version file. It does feel somewhat extra. There's also references to the revision in the .admx and .adml for that.
No need to up the revision here since we're only removing the namespace, but that'll be needed for the future.
What about just adding it in comment to the .admx instead of adding a new file, since it already contains the revision? <!-- PowerToys 0.64.0 -->
Comment sounds good too. The revision 1 was only for the "using" fix. |
Hi @htcfreek , added the PowerToys version next to the needed revision. LGTY? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution! 😉
Merging so we can include in the hotfix. Other formats may be done for 0.65 if needed. |
* fix admx file * add version info file * Add PowerToys version in admx instead
Summary of the Pull Request
There was an obsolete using that prevented users from import into Intune management.
PR Checklist
Detailed Description of the Pull Request / Additional comments
In addition to the fix this PR adds a version information file. This file helps users to identify the downloaded admx later.
Validation Steps Performed
nothing