Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPO] Fix the admx file by removing obsolete using #21813

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Nov 6, 2022

Summary of the Pull Request

There was an obsolete using that prevented users from import into Intune management.

PR Checklist

Detailed Description of the Pull Request / Additional comments

In addition to the fix this PR adds a version information file. This file helps users to identify the downloaded admx later.

Validation Steps Performed

nothing

@htcfreek
Copy link
Collaborator Author

htcfreek commented Nov 6, 2022

@jaimecbernardo
Are you okay with the new version file?
Do we need some additional changes to add the version file to the release download asset?

@htcfreek htcfreek self-assigned this Nov 6, 2022
@htcfreek htcfreek added Issue-Bug Something isn't working Area-Enterprise Issues relevant to large enterprises, SCCM, run as admin restrictions, ... labels Nov 6, 2022
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'm OK with the version file. It does feel somewhat extra. There's also references to the revision in the .admx and .adml for that.
No need to up the revision here since we're only removing the namespace, but that'll be needed for the future.
What about just adding it in comment to the .admx instead of adding a new file, since it already contains the revision? <!-- PowerToys 0.64.0 -->

@htcfreek
Copy link
Collaborator Author

htcfreek commented Nov 7, 2022

Comment sounds good too. The revision 1 was only for the "using" fix.

@jaimecbernardo
Copy link
Collaborator

Hi @htcfreek , added the PowerToys version next to the needed revision. LGTY?

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution! 😉

@jaimecbernardo
Copy link
Collaborator

Merging so we can include in the hotfix. Other formats may be done for 0.65 if needed.

@jaimecbernardo jaimecbernardo merged commit 7181626 into microsoft:main Nov 7, 2022
jaimecbernardo pushed a commit that referenced this pull request Nov 7, 2022
* fix admx file

* add version info file

* Add PowerToys version in admx instead
@htcfreek htcfreek deleted the PT_GpoFix branch November 7, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Enterprise Issues relevant to large enterprises, SCCM, run as admin restrictions, ... Issue-Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants