Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FancyZones now does its own event processing #2347

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

ivan100sic
Copy link
Contributor

Summary of the Pull Request

This PR moves the code which creates and uses WinHooks used in FancyZones from PowerToys to the FancyZones module, without affecting other modules.

References

Relevant issue: #961

PR Checklist

  • Applies to Multithreaded design simplification  #961
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Manually tested the FancyZones module, also tried disabling it and then enabling it again.

@enricogior enricogior added this to In progress in 0.18 release via automation Apr 23, 2020
@enricogior enricogior added the Area-Quality Stability, Performance, Etc. label Apr 23, 2020
@enricogior
Copy link
Contributor

The code review for this PR is less urgent compared to the PRs for 0.17.

Copy link
Contributor

@yevhenii44-zz yevhenii44-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested and it works good

Copy link
Contributor

@vldmr11080 vldmr11080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and both keyboard and win hook work as expected. Code looks good.

@ivan100sic ivan100sic merged commit 313b1b3 into microsoft:master Apr 30, 2020
0.18 release automation moved this from In progress to Done Apr 30, 2020
@ivan100sic ivan100sic deleted the fancyzones-unhook branch April 30, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Quality Stability, Performance, Etc.
Projects
No open projects
0.18 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants