Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments #24254

Merged
merged 4 commits into from Feb 22, 2023
Merged

Adjustments #24254

merged 4 commits into from Feb 22, 2023

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Feb 22, 2023

Summary of the Pull Request

adjustments based based on policheck

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@microsoft microsoft deleted a comment from github-actions bot Feb 22, 2023
@microsoft microsoft deleted a comment from github-actions bot Feb 22, 2023
@crutkas crutkas marked this pull request as ready for review February 22, 2023 17:22
@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Feb 22, 2023
jaimecbernardo
jaimecbernardo approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crutkas crutkas merged commit d122f7f into main Feb 22, 2023
@crutkas crutkas deleted the dev/crutkas/policheckTweaks1 branch February 22, 2023 22:55
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
@crutkas @BLM16
Adjustments (microsoft#24254)
631eea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crutkas @jaimecbernardo