Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PowerAccent character list #24818

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Update PowerAccent character list #24818

merged 1 commit into from
Mar 22, 2023

Conversation

stevenlele
Copy link
Contributor

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Some issues that should be decided on:

  • The criterion for adding characters to "All"
  • Sorting the characters in "All"
  • We should do Canonical Composition (e+◌́ → é).
  • Should we allow adding "letter + combinational mark" sequences, or should we force users to input separately for clarity? (Pinyin section still has some of those sequences)
  • We probably want to force single combinational marks to be escaped (\uXXXX) in source code.

I'll write a new issue to discuss these issues.

Validation Steps Performed

N/A

@stevenlele
Copy link
Contributor Author

@microsoft-github-policy-service agree

@stefansjfw
Copy link
Collaborator

@damienleroy FYI

stefansjfw
stefansjfw approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

Let's open a new issue as you suggested to discuss additional changes, like adding characters to ALL, etc..

@stefansjfw stefansjfw merged commit dcfc169 into microsoft:main Mar 22, 2023
@stevenlele stevenlele deleted the accent branch March 22, 2023 09:43
@stevenlele stevenlele mentioned this pull request Mar 29, 2023
Open
@stevenlele
Copy link
Contributor Author

Meta issue opened: #25089

@Wenti-D Wenti-D mentioned this pull request Apr 5, 2023
Closed
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
@stevenlele @BLM16
Update PowerAccent character list (microsoft#24818)
5075ac4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefansjfw stefansjfw stefansjfw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevenlele @stefansjfw