[Peek] Implementation of a performant and reliable Neighboring Files Query

[SamChaps]

Summary of the Pull Request

• Get file neighbors via querying the IFolderView and consuming the IShellItemArray interface
• Enable getting neighbors from any indexes rapidly
• Abstract IShellItemArray with a custom read only list implementation NeighboringItems
• Simplify NeighboringItemsQuery
• Add IoC container to facilitate dependency injection

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (15)

ALLVIEW
Chromakey
GETPROPERTYSTOREFLAGS
holemenu
IFile
IPalette
ipreview
pkey
ppshv
Rasterize
rbhid
SHCONTF
SHGDNF
SIATTRIBFLAGS
Strm

Previously acknowledged words that are now absent

Asn BESTEFFORT BHIDSF Brotli clrcompression clretwrc clrgc clrjit Cng coreclr dbgshim DCompiler DELAYCREATION Dwma EXTRINSICPROPERTIESONLY FASTPROPERTIESONLY HANDLERPROPERTIESONLY hostfxr hostpolicy IIDI Imc Intrinsics IPREVIEW JSONOf Keybd LANGID mscordaccore mscordbi mscorrc msquic neighborings netstandard OPENSLOWITEM OPLOCK Pkcs PKEY PREFERQUERYPROPERTIES Previer psfi Quic rfid RTSS Shcontf Shgno Softcoded Ssl UMsg WMSDK wpfgfx WScan WVk zopfli :arrow_right:

Some files were automatically ignored

These sample patterns would exclude them:

^\Qsrc/modules/peek/Peek.Common/NativeMethods.txt\E$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the git@github.com:microsoft/PowerToys.git repository
on the sachaple/peek-nfq branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4481156300/attempts/1'

Available 📚 dictionaries could cover words not in the 📘 dictionary

This includes both expected items (2294) from .github/actions/spell-check/expect.txt and unrecognized words (15)

Dictionary	Entries	Covers
cspell:win32/src/win32.txt	53509	134
cspell:cpp/src/cpp.txt	30216	129
cspell:python/src/python/python-lib.txt	3873	32
cspell:php/php.txt	2597	17
cspell:node/node.txt	1768	13
cspell:typescript/typescript.txt	1211	12
cspell:python/src/python/python.txt	453	11
cspell:java/java.txt	7642	11
cspell:aws/aws.txt	218	8
cspell:python/src/common/extra.txt	741	7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:win32/src/win32.txt
          cspell:cpp/src/cpp.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''

Warnings (1)

See the 📂 files view or the 📜action log for details.

ℹ️ Warnings	Count
ℹ️ noisy-file	1

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[SeraphimaZykova]

I've given it a test and noticed a Peek window opens on its own with an infinite loading right after launching PowerToys runner.

[SamChaps]

I've given it a test and noticed a Peek window opens on its own with an infinite loading right after launching PowerToys runner.

Let me test it again.

[SamChaps]

I've given it a test and noticed a Peek window opens on its own with an infinite loading right after launching PowerToys runner.

Let me test it again.

Seems to be working correctly on my side.

[SeraphimaZykova]

I've given it a test and noticed a Peek window opens on its own with an infinite loading right after launching PowerToys runner.

Let me test it again.

Seems to be working correctly on my side.

It happened to me several times in a row, but after I rebuilt the project for another test it's not reproducible anymore. So probably something went wrong on my side. Sorry for the false alarm.

[SeraphimaZykova]

I've given it a test and noticed a Peek window opens on its own with an infinite loading right after launching PowerToys runner.

Let me test it again.

Seems to be working correctly on my side.

The problem is 100% reproducible on the release build, while debug works as expected. And this is also reproduced in the Peek main branch, so the issue is irrelevant to the latest changes.

Untitled.video.-.Made.with.Clipchamp.mp4