Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings] MWB and Peek improvements #26142

Merged
merged 4 commits into from May 25, 2023
Merged

[Settings] MWB and Peek improvements #26142

merged 4 commits into from May 25, 2023

Conversation

niels9001
Copy link
Contributor

  • Adding/fixing documentation links for Peek and MWB (as they were missing)
    image

  • Improvements to the MWB layout UI reflecting OS display management:
    Before vs. after

image

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@yuyoyuppe
Copy link
Collaborator

That looks so much cooler 😄

Jay-o-Way
Jay-o-Way suggested changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

src/settings-ui/Settings.UI/Views/MouseWithoutBordersPage.xaml Outdated Show resolved Hide resolved
src/settings-ui/Settings.UI/Views/MouseWithoutBordersPage.xaml Outdated Show resolved Hide resolved
src/settings-ui/Settings.UI/Views/MouseWithoutBordersPage.xaml Outdated Show resolved Hide resolved
src/settings-ui/Settings.UI/Views/MouseWithoutBordersPage.xaml Show resolved Hide resolved
src/settings-ui/Settings.UI/Views/MouseWithoutBordersPage.xaml Show resolved Hide resolved
src/settings-ui/Settings.UI/Views/MouseWithoutBordersPage.xaml Show resolved Hide resolved
src/settings-ui/Settings.UI/Views/MouseWithoutBordersPage.xaml Outdated Show resolved Hide resolved
@niels9001
Copy link
Contributor Author

@Jay-o-Way Good feedback - addressed!

@niels9001 niels9001 requested a review from Jay-o-Way May 23, 2023 22:23
jaimecbernardo
jaimecbernardo requested changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes :)
Looking much better.
Here's a nit:
image
I think that should be ID instead of placeholder (MWB_SecurityKeyLabel)
Other than that, LGTM!

@jaimecbernardo jaimecbernardo added this to In progress in 0.71 Release via automation May 24, 2023
@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label May 24, 2023
@niels9001
Copy link
Contributor Author

Thanks for the fixes :) Looking much better. Here's a nit: image I think that should be ID instead of placeholder (MWB_SecurityKeyLabel) Other than that, LGTM!

Whoops.. fixed :-)!

Jay-o-Way
Jay-o-Way reviewed May 24, 2023
View reviewed changes
Copy link
Collaborator

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saying

src/settings-ui/Settings.UI/Views/MouseWithoutBordersPage.xaml Show resolved Hide resolved
jaimecbernardo
jaimecbernardo approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 667aad2 into main May 25, 2023
10 checks passed
0.71 Release automation moved this from In progress to Done May 25, 2023
@crutkas crutkas deleted the niels9001/settings-improvements branch June 1, 2023 03:48
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
@niels9001 @BLM16
[Settings] MWB and Peek improvements (microsoft#26142)
8b1c0fd 
* Improvements to MWB

* Adding link to Peek

* Address feedback

* Fix localization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-o-Way Jay-o-Way Jay-o-Way requested changes

@yuyoyuppe yuyoyuppe yuyoyuppe approved these changes

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
Hot Fix Items we will product an out-of-band release for
Projects
No open projects
0.71 Release
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@niels9001 @yuyoyuppe @jaimecbernardo @Jay-o-Way