[Peek]Create Setting to run not elevated #26308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimecbernardo
added
the
Hot Fix
SamChaps
approved these changes
May 25, 2023
BLM16
pushed a commit
to BLM16/PowerToys
that referenced
this pull request
Jun 22, 2023
* [Peek]Create Setting to run not elevated * Optionally add access permissions to the handles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add a Setting to always run Peek not elevated, which is on by default.
If running Peek un-elevated brings other issues, the users can still manipulate the Setting to troubleshoot.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Uses the same process to create Peek that PowerToys Run uses when trying to run non-elevated.
Changes the process handle we get for starting non-elevated to also get a PROCESS_TERMINATE permission.
Validation Steps Performed
Created a network share through
net use t: \\localhost\c$\tempshareand verified that Peek didn't work on 0.70.0 when running elevated but it works with this change and the Setting turned on.