-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Peek] Use effective pixels for unsupported previewer #26345
[Peek] Use effective pixels for unsupported previewer #26345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look on the normal 100% scaling factor, the fonts are too small. Thanks
What is your monitor resolution? I have a 2k monitor and it looks good at 100% If your monitor is 4k and you use 100% I would expect the text to be very small just like the rest of Windows text. Text scaling should happen automatically with XAML, I don't think manually changing the font size is a viable option. |
Hi Sam, |
Do you notice similar behavior with other apps or Peek's behavior is different? |
It was with peek only. With the new commit the preview of unsupported files looks great with any scale factor. 100%, 250%. |
Summary of the Pull Request
Use effective pixels for unsupported previewer allowing to nicely display on any monitor scale.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Tested on different monitor scale.