Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[monaco][dev files preview][Peek] Support .vbproj and .fsproj #26431

Merged
merged 2 commits into from May 29, 2023
Merged

[monaco][dev files preview][Peek] Support .vbproj and .fsproj #26431

merged 2 commits into from May 29, 2023

Conversation

stefansjfw
Copy link
Collaborator

Summary of the Pull Request

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@stefansjfw stefansjfw changed the title [monaco][dev files prev][Peek] Support .vbproj and .fsproj [monaco][dev files preview][Peek] Support .vbproj and .fsproj May 29, 2023
jaimecbernardo
jaimecbernardo approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefansjfw stefansjfw merged commit 6107315 into main May 29, 2023
10 checks passed
@stefansjfw stefansjfw deleted the stefan/monaco_fsproj_vbproj branch May 29, 2023 12:52
@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label May 30, 2023
@jaimecbernardo jaimecbernardo added this to In progress in 0.71 Release via automation May 30, 2023
@jaimecbernardo jaimecbernardo moved this from In progress to Done in 0.71 Release May 30, 2023
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
@stefansjfw @BLM16
[monaco][dev files prev][Peek] Support .vbproj and .fsproj (microsoft…
0f3bbb0 
…#26431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

@Aaron-Junker Aaron-Junker Awaiting requested review from Aaron-Junker

Assignees
No one assigned
Labels
Hot Fix Items we will product an out-of-band release for
Projects
No open projects
0.71 Release
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefansjfw @jaimecbernardo