Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Peek] Fix race condition when setting preview #26478

Merged
merged 1 commit into from May 30, 2023
Merged

[Peek] Fix race condition when setting preview #26478

merged 1 commit into from May 30, 2023

Conversation

stefansjfw
Copy link
Collaborator

Summary of the Pull Request

All 3 tasks awaited in LoadPreviewAsync are setting Preview. Therefore, there was a race condition causing low (or high) quality thumbnail was shown even when full image was available.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

yuyoyuppe
yuyoyuppe approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@yuyoyuppe yuyoyuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is sound, LGTM 🙂

@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label May 30, 2023
@jaimecbernardo jaimecbernardo added this to In progress in 0.71 Release via automation May 30, 2023
jaimecbernardo
jaimecbernardo approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM! The pictures I was seeing that were not being shown correctly are being shown well again. Thank you!

SeraphimaZykova
SeraphimaZykova approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Images are shown correctly and memory consumption still looks adequate.

@jaimecbernardo jaimecbernardo merged commit b50b587 into main May 30, 2023
10 checks passed
0.71 Release automation moved this from In progress to Done May 30, 2023
@stefansjfw stefansjfw deleted the stefan/peek_fix_sync_issue branch May 31, 2023 14:45
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
@stefansjfw @BLM16
[Peek] Fix race condition when setting preview (microsoft#26478)
0b7ea08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyoyuppe yuyoyuppe yuyoyuppe approved these changes

@SeraphimaZykova SeraphimaZykova SeraphimaZykova approved these changes

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

@SamChaps SamChaps Awaiting requested review from SamChaps

Assignees
No one assigned
Labels
Hot Fix Items we will product an out-of-band release for
Projects
No open projects
0.71 Release
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stefansjfw @yuyoyuppe @SeraphimaZykova @jaimecbernardo