Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WPFUI version to preview-13 to fix scrollbar issue #30859

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Jan 10, 2024

Summary of the Pull Request

This PR bumps WPFUI to preview-13. It contains a scrollbar fix, so that we can now fix: #30318 and #30862

Before:
image

After:
image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@jaimecbernardo
Copy link
Collaborator

Might this fix #30862 as well?

@niels9001
Copy link
Contributor Author

Might this fix #30862 as well?

Ah yes, that is correct! I fixed that in the same PR for the scrollbar position. Will tag that issue as well.

@niels9001 niels9001 added Run-Plugin Things that relate with PowerToys Run's plugin interface and removed Run-Plugin Things that relate with PowerToys Run's plugin interface labels Jan 10, 2024
@jaimecbernardo
Copy link
Collaborator

Hi,
Thanks for opening this PR.
CI has been failing on the PR due to an update to .NET 8.0.1 in the CI machines. This should've been fixed in #30892 , which was just merged.
Can you please merge main in your PR so that CI can run correctly?
Thank you 😄

@niels9001
Copy link
Contributor Author

Hi, Thanks for opening this PR. CI has been failing on the PR due to an update to .NET 8.0.1 in the CI machines. This should've been fixed in #30892 , which was just merged. Can you please merge main in your PR so that CI can run correctly? Thank you 😄

Done!

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Jan 11, 2024
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit f8d075f into main Jan 12, 2024
14 checks passed
@crutkas crutkas deleted the niels9001/wpfui-preview13 branch January 31, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing margins in PowerToys Run results
3 participants