Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run] Remove unused settings #30865

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

davidegiacometti
Copy link
Collaborator

Summary of the Pull Request

  • Remove unused PT Run settings from the Wox porting
  • public string ResultFont { get; set; } = FontFamily.GenericSansSerif.Name; was causing ExternalException: A generic error occurred in GDI+.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tested PT Run and settings working as expected.

@jaimecbernardo
Copy link
Collaborator

Hi,
Thanks for opening this PR.
CI has been failing on the PR due to an update to .NET 8.0.1 in the CI machines. This should've been fixed in #30892 , which was just merged.
Can you please merge main in your PR so that CI can run correctly?
Thank you 😄

@davidegiacometti davidegiacometti force-pushed the users/davidegiacometti/run-settings-cleanup branch from e58726a to e57f880 Compare January 11, 2024 16:35
@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Jan 11, 2024
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice clean-up! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 1477983 into main Jan 12, 2024
14 checks passed
@davidegiacometti davidegiacometti deleted the users/davidegiacometti/run-settings-cleanup branch January 12, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants