Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Actions menu #31220

Open
wants to merge 89 commits into
base: main
Choose a base branch
from
Open

File Actions menu #31220

wants to merge 89 commits into from

Conversation

Aaron-Junker
Copy link
Collaborator

@Aaron-Junker Aaron-Junker commented Feb 1, 2024

Summary of the Pull Request

Adding a new menu invokable by selecting files in explorer and pressing a shortcut set in the settings.

Screenshots

image
image
image
image
image
image
image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Things left to do:

  • Add installer
  • Add icon
  • DPI Awareness

Validation Steps Performed

</ui:MenuItem.Icon>
</ui:MenuItem>
<Separator/>
<ui:MenuItem Header="Copy path of files sperated by">

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[sperated](#security-tab) is not a recognized word. \(unrecognized-spelling\)
@Aaron-Junker
Copy link
Collaborator Author

@niels9001 Do you have an idea why the contextmenu doesn't take the WPFUI style?

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

This comment has been minimized.

@Aaron-Junker
Copy link
Collaborator Author

@jaimecbernardo This PR should be ready for review again. Installer works now and I removed some changes I didn't want to make. The changes in Peek are intentional.

The only thing missing now is the icon from @niels9001.

@Aaron-Junker
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Aaron-Junker
Copy link
Collaborator Author

Ok seems like I have to move the xaml files to FilesActionsMenuXAML. But when I do that (latest commit) I only get the winui2 style and MainWindow.xaml doesn't seem to respect App.xaml.

image

cc: @niels9001

@Aaron-Junker Aaron-Junker changed the title File actions menu File Actions menu Apr 7, 2024
@Aaron-Junker
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

NOTICE.md Fixed Show fixed Hide fixed

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants