Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing any nuget configuration that might be coming from parent dir… #4596

Merged
merged 1 commit into from Jun 30, 2020

Conversation

martinchrzan
Copy link
Contributor

@martinchrzan martinchrzan commented Jun 30, 2020

…ectories, fixes #4595

Summary of the Pull Request

Clearing any nuget configuration that might be coming from parent directories. Setting global cache for nuget packages causes overriding our local nuget references and preventing solution build from working.
Adding project level nuget.config which overrides any unwanted parent config.

References

PR Checklist

  • Applies to Nuget restore and build fails  #4595
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

I wasn't able to build the project before this change, now it builds successfully.

Copy link
Contributor

@enricogior enricogior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinchrzan martinchrzan merged commit 423cd20 into master Jun 30, 2020
@enricogior
Copy link
Contributor

@martinchrzan-mfst
for future reference, we use "Squash and merge" as primary option, "Rebase and merge" as second option.

@martinchrzan martinchrzan deleted the user/martinchrzan/nugetConfig branch June 30, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuget restore and build fails
3 participants