Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner: initialize COM security, so toast notifications work in elevated context from non-admin account #5314

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

yuyoyuppe
Copy link
Collaborator

Summary of the Pull Request

To avoid 0x80070005 (Access denied) error in wpnapps.dll when trying to show toast in the context described in the title, it's crucial to add L"(A;;0x7;;;IU)" permission to the COM security descriptor and initialize COM with it.

PR Checklist

Validation Steps Performed

  • launched PowerToys from an elevated cmd shell from non-admin account

@yuyoyuppe
Copy link
Collaborator Author

I suggest we merge it once the 0.20.x is released to avoid regressions, since this PR could have unpredicted side-effects.

@enricogior enricogior added the Area-Runner The PowerToys main executable label Jul 30, 2020
@enricogior enricogior added this to In progress in 0.21 release via automation Jul 30, 2020
0.21 release automation moved this from In progress to Reviewer approved Aug 5, 2020
@enricogior
Copy link
Contributor

Tested, it worked as expected.

@yuyoyuppe yuyoyuppe merged commit 59ebe30 into microsoft:master Aug 5, 2020
0.21 release automation moved this from Reviewer approved to Done Aug 5, 2020
@yuyoyuppe yuyoyuppe deleted the issue_5313 branch August 5, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Runner The PowerToys main executable
Projects
No open projects
0.21 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants