Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageResizer new icon #6443

Merged
merged 1 commit into from Sep 8, 2020
Merged

ImageResizer new icon #6443

merged 1 commit into from Sep 8, 2020

Conversation

enricogior
Copy link
Contributor

Summary of the Pull Request

Use the new icon:

image

PR Checklist

Validation Steps Performed

Build solution, build msi, install msi, verify new cion is used (may require a Windows reboot to reset the icon cache)

@enricogior
Copy link
Contributor Author

@bricelam
while updating the icon, I noticed there is also a .png file
https://github.com/microsoft/PowerToys/blob/master/src/modules/imageresizer/ui/Resources/ImageResizer.png
that doesn't seems to be used anywhere, can it be deleted?

@Aaron-Junker
Copy link
Collaborator

But this icon isnt like the other PowerToys icons

@niels9001
Copy link
Contributor

niels9001 commented Sep 8, 2020

@enricogior Could you make a screenshot of the usage of the icon in the right-click context menu and in the window titlebar and post it here?

@Aaron-Junker It is actually - it follows the new design language for Fluent Design icons that you see popping up across Windows. The FancyZones editor has a similar icon, and also other OS features like OneDrive use these in shell context menu's.

@enricogior
Copy link
Contributor Author

image

image

@Aaron-Junker
Copy link
Collaborator

Oh ok. Cool.

Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@enricogior enricogior merged commit c5f9027 into master Sep 8, 2020
@enricogior enricogior deleted the dev/enricogior/imageresize_icon branch September 8, 2020 09:30
@bricelam
Copy link
Contributor

bricelam commented Sep 8, 2020

I noticed there is also a .png file that doesn't seems to be used anywhere, can it be deleted?

Yes, it can be deleted. It used to appear on the About page of the Advanced settings dialog before that dialog was assimilated into the main PowerToys Settings dialog. It was also used by the installer.

@enricogior
Copy link
Contributor Author

@bricelam
OK, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants